Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tidy godoc #347

Closed
wants to merge 13 commits into from
Closed

tidy godoc #347

wants to merge 13 commits into from

Conversation

bashbunni
Copy link
Member

The enumerators weren't rendering properly in the godoc and I found other areas that could be improved along the way. Doing this in a separate PR so it's easier to review :)

I ran godoc -http=localhost:6060 to check these changes locally

bashbunni and others added 13 commits July 23, 2024 17:20
@bashbunni @caarlos0
feat: support any type for list Root func
15e8596 
Signed-off-by: Carlos Alexandro Becker <[email protected]>
@caarlos0
feat: move tree to root
790ba42 
Signed-off-by: Carlos Alexandro Becker <[email protected]>
@caarlos0
feat: more cleanup
d0570f7 
Signed-off-by: Carlos Alexandro Becker <[email protected]>
@bashbunni
docs(examples): bring back tree examples
4633a3e
@meowgorithm
docs(examples): add tree toggle example
304d03f
@meowgorithm
docs(examples): fix toggle tree hierarchy; as bashbunni metadata
fcfc436
@bashbunni
fix(tree): stylize whitespace when vertically joining tree elements
269ae9f
@bashbunni
docs: get started with trees
88a3d2f
@bashbunni
feat: add RootStyle with example
c613d6f
@bashbunni
test: add test for RootStyle func
e19fbfe
@bashbunni
docs(godoc): replace list mentions in tree package
81029f5
@bashbunni
refactor(examples): use Root shorthand instead of tree.New where appl…
c1c679a 
…icable
@bashbunni
chore: tidy tree godoc
f0de4ff
@bashbunni bashbunni added the documentation Improvements or additions to documentation label Aug 8, 2024
Base automatically changed from bring-tree-back-v2 to master August 19, 2024 18:43
@bashbunni bashbunni closed this Aug 20, 2024
@bashbunni bashbunni deleted the tree/godoc branch August 20, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meowgorithm meowgorithm Awaiting requested review from meowgorithm meowgorithm is a code owner

@aymanbagabas aymanbagabas Awaiting requested review from aymanbagabas aymanbagabas is a code owner

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bashbunni @caarlos0 @meowgorithm