(v2) feat: combine keyboard enhancements into a nicer API #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meowgorithm
reviewed
Sep 17, 2024
This change combines the keyboard enhancements into a nicer API. Kitty keyboard protocol and XTerm modifyOtherKeys are now combined into a single API. This makes it easier to enable keyboard enhancements. Use `WithKeyboardEnhancements` to enable keyboard enhancements. This function accepts a list of `KeyboardEnhancement` functions that can be used to enable different keyboard features. For now, we only support the `WithReleaseKeys` enhancement which enables support for reporting release key events.
aymanbagabas
force-pushed
the
v2-enhanced-keyboard
branch
from
e506b60
to
390631c
Compare
Co-authored-by: Christian Rocha <[email protected]>
aymanbagabas
changed the title
meowgorithm
approved these changes
Sep 17, 2024
aymanbagabas
force-pushed
the
v2-enhanced-keyboard
branch
from
60e6260
to
f6e468f
Compare
aymanbagabas
force-pushed
the
v2-enhanced-keyboard
branch
from
f6e468f
to
c80b0d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change combines the keyboard enhancements into a nicer API. Kitty keyboard protocol and XTerm modifyOtherKeys are now combined into a single API. This makes it easier to enable keyboard enhancements.
Use
WithKeyboardEnhancementsto enable keyboard enhancements. This function accepts a list ofKeyboardEnhancementfunctions that can be used to enable different keyboard features.For now, we only support the
WithKeyReleasesenhancement which enables support for reporting release key events.