Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up Docker test job to allow publishing release images #26046

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

riftEmber
Copy link
Member

@riftEmber riftEmber commented Oct 7, 2024

Refactor the Docker nightly testing script to optionally also push release-tagged images.

Configured by the RELEASE_VERSION environment variable, assumed to get set via Jenkins parameter. If set, the script pushes the images tagged as latest and $RELEASE_VERSION. All nightly build/pushes still run before release-tagged pushes, so we don't push a release if any image variants are broken. Script aborts without building anything if RELEASE_VERSION is set but we're not on the appropriate release branch.

As part of this PR I attempted to change our process to test the image before pushing, rather than build, push, then test. However, on chapelmac-m1 this ran into docker/buildx#59, so I reverted it. Since we only push release images after all nightly images, we're still safe from pushing a broken release-tagged image. Noted this limitation and the requirement to build nightly images first in a comment.

Resolves https://github.com/Cray/chapel-private/issues/6743.

Associated pre-merge tasks:

Testing:

  • manual run in non-release mode still works
  • manual run in release mode (temporarily modified to push to a scratch repo)

@riftEmber riftEmber marked this pull request as ready for review October 7, 2024 17:59
@riftEmber riftEmber force-pushed the docker-release-job branch 9 times, most recently from 6d01658 to fc39ae0 Compare October 8, 2024 17:18
Signed-off-by: Anna Rift <[email protected]>
Includes comment describing Docker limitation motivating this.
Also correctly remove tagged image name pre-build.

Signed-off-by: Anna Rift <[email protected]>
To be more robust against unnecessary rebuilds

Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant