Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dyno: Fix bugs that were breaking chpl-language-server tests #26007

Conversation

dlongnecke-cray
Copy link
Contributor

@dlongnecke-cray dlongnecke-cray commented Sep 26, 2024

This PR fixes bugs that were causing test failures in chpl-language-server.

Make sure to skip resolving function bodies in resolveFunction if the function does not have one (e.g., for extern functions).

If typedSignatureInitial is called on a nested function and parent frames are not present, emit a warning and continue if the parent(s) are generic instead of returning nullptr. Future work should make typedSignatureInitial take the parent function signature instead.

Reviewed by @mppf. Thanks!

TESTING

  • linux64, standard
  • test-chpl-language-server

@dlongnecke-cray dlongnecke-cray changed the title dyno: Adjust 'resolveFunction' to give up if the function is 'extern' dyno: Fix bugs that were breaking chpl-language-server tests Sep 27, 2024
@dlongnecke-cray dlongnecke-cray removed the request for review from mppf September 27, 2024 03:40
@dlongnecke-cray
Copy link
Contributor Author

@mppf Daniel pointed out some logic bugs that I should fix first before I ping you for review.

@dlongnecke-cray dlongnecke-cray merged commit d4fbd00 into chapel-lang:main Sep 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants