[dyno] map owned to _owned module code #25617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arezaii
force-pushed
the
dyno-map-owned
branch
4 times, most recently
from
dd3e36b
to
765e594
Compare
arezaii
force-pushed
the
dyno-map-owned
branch
4 times, most recently
from
3204692
to
327c770
Compare
arezaii
force-pushed
the
dyno-map-owned
branch
2 times, most recently
from
a3d9088
to
cf29867
Compare
DanilaFe
reviewed
Aug 14, 2024
arezaii
force-pushed
the
dyno-map-owned
branch
2 times, most recently
from
e7ee7c4
to
3b7b3fc
Compare
arezaii
commented
Aug 28, 2024
arezaii
force-pushed
the
dyno-map-owned
branch
2 times, most recently
from
9d3eea5
to
07f3f22
Compare
DanilaFe
approved these changes
Sep 3, 2024
Signed-off-by: Ahmad Rezaii <[email protected]>
Signed-off-by: Ahmad Rezaii <[email protected]>
Signed-off-by: Ahmad Rezaii <[email protected]>
Signed-off-by: Ahmad Rezaii <[email protected]>
Signed-off-by: Ahmad Rezaii <[email protected]>
Signed-off-by: Ahmad Rezaii <[email protected]>
* expand owned and _owned resolution tests * expand shared and _shared resolution tests Signed-off-by: Ahmad Rezaii <[email protected]>
Signed-off-by: Ahmad Rezaii <[email protected]>
Signed-off-by: Ahmad Rezaii <[email protected]>
Signed-off-by: Ahmad Rezaii <[email protected]>
Signed-off-by: Ahmad Rezaii <[email protected]>
Signed-off-by: Ahmad Rezaii <[email protected]>
arezaii
force-pushed
the
dyno-map-owned
branch
from
7c56cc8
to
14f7453
Compare
Signed-off-by: Ahmad Rezaii <[email protected]>
Signed-off-by: Ahmad Rezaii <[email protected]>
arezaii
changed the title
DanilaFe
approved these changes
Sep 26, 2024
Signed-off-by: Ahmad Rezaii <[email protected]>
Signed-off-by: Ahmad Rezaii <[email protected]>
Signed-off-by: Ahmad Rezaii <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for mapping
ownedto the_ownedrecord implementation in module code. Resolves https://github.com/Cray/chapel-private/issues/6157.There were many parts needed to make this work.
First, add the manager's scope when evaluating a class receiver's scope.
Then, normalize managed classes to their managers, and then do the can-pass evaluation on the now similar types.
Additional changes were required to allow
nilto be instantiated for a nilable class and for accessing a field of the manager while evaluating the body of a type method onowned.The change includes similar patterns for
_ownedand_sharedso implements some tests for both.[reviewed by @DanilaFe - thank you!]