LSP: make use of pytest-lsp to start testing some core features #25011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Danila Fedorin <[email protected]>
jabraham17
approved these changes
May 8, 2024
Comment on lines
+7
to
+8
| pytest==8.2.0 | ||
| pytest-lsp==0.4.1 |
There was a problem hiding this comment.
This makes me pause a little. Why are we now requiring all users of cls/chplcheck to have dependencies that are only used for development testing purposes.
In my opinion, these should be in a separate venv (like test-venv). Maybe chapel-py-test-venv?
Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Danila Fedorin <[email protected]>
Merged
jabraham17
added a commit
that referenced
this pull request
May 20, 2024
Expands the work of @DanilaFe in #25011 to add more tests of CLS, Chapels language server implementation. Infrastructure changes - Moved test-only python dependencies into their own venv - Refactored and split up the monolithic `test_server.py` - all top level python files are considered test files, helper files can be hidden in sub directories - this also allows for tests to be defined in multiple files to logically group them Added tests for the following features - Resolving nested directories - resolution tests - call inlays - type inlays - diagnostics - param inlays - document symbols - end markers - code lenses (show generic, show instantiation) Bugs fixed as a result of writing tests - goto-type-def should use `name_location` when possible - fix type inlay bug with implicit this - fix document symbols inconsistencies - fix off-by-one location error - fix end marker inlays rendering incorrectly - fix type variable locations [Reviewed by @DanilaFe]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The title about says it all. This adds
pytest-lspto thechplcheck-requirements.txtfile (which effectively is thechapel-py-requirements.txtat this point), and adds a newMakefiletarget to run the tests. It also locks down go-to-definition, autocompletion, and reference finding.Reviewed by @jabraham17 -- thanks!