Mark some Reflection procedures as unstable #22799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Longnecker <[email protected]>
Signed-off-by: David Longnecker <[email protected]>
Signed-off-by: David Longnecker <[email protected]>
Signed-off-by: David Longnecker <[email protected]>
Signed-off-by: David Longnecker <[email protected]>
dlongnecke-cray
force-pushed
the
reflection-mark-unstable
branch
from
33cf424
to
89b8dd3
Compare
vasslitvinov
approved these changes
Jul 27, 2023
Signed-off-by: David Longnecker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark some
Reflectionprocedures as unstable after module review.One routine
numFieldshas been deprecated in favor of areplacement named
getNumFields().Refer to: https://github.com/Cray/chapel-private/issues/5022
The
Reflectionprocedures marked unstable by this PR are:isFieldBoundgetFieldRefcanResolvecanResolveMethodcanResolveTypeMethodWhile here, I adjusted the prediff for
TestWarnUnstableSuppressionso that any symbols mentioned besides the special symbols used
for this test are filtered out of the output.
TESTING
linux64,standardReviewed by @vasslitvinov. Thanks!