Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename BigInteger div/mul family of functions #22794

Merged
merged 19 commits into from
Jul 26, 2023
Merged

Rename BigInteger div/mul family of functions #22794

merged 19 commits into from
Jul 26, 2023

Commits on Jul 25, 2023

  1. remove long deprecated divexact overload, is_congruent, and is_divisi… 

    …ble functions

Signed-off-by: Jade Abraham <[email protected]>
    @jabraham17
    jabraham17 committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    72c72d1 View commit details
    Browse the repository at this point in the history

  2. rename mul_2exp 

    Signed-off-by: Jade Abraham <[email protected]>
    @jabraham17
    jabraham17 committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    25a3f73 View commit details
    Browse the repository at this point in the history

  3. remove div_qr, div_r, div_q_2exp, and div_r_2exp 

    leave div_q for now

Signed-off-by: Jade Abraham <[email protected]>
    @jabraham17
    jabraham17 committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    57730bd View commit details
    Browse the repository at this point in the history

  4. add comment to test 

    Signed-off-by: Jade Abraham <[email protected]>
    @jabraham17
    jabraham17 committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    bbf5d52 View commit details
    Browse the repository at this point in the history

  5. deprecate div family of functions 

    Signed-off-by: Jade Abraham <[email protected]>
    @jabraham17
    jabraham17 committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    017a300 View commit details
    Browse the repository at this point in the history

  6. add the shift functions in bigint 

    Signed-off-by: Jade Abraham <[email protected]>
    @jabraham17
    jabraham17 committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    c551e11 View commit details
    Browse the repository at this point in the history

  7. fix links in doc 

    Signed-off-by: Jade Abraham <[email protected]>
    @jabraham17
    jabraham17 committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    a66265f View commit details
    Browse the repository at this point in the history

  8. update deprecation messages where needed 

    Signed-off-by: Jade Abraham <[email protected]>
    @jabraham17
    jabraham17 committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    a602b95 View commit details
    Browse the repository at this point in the history

  9. update tests as needed for div functions 

    Signed-off-by: Jade Abraham <[email protected]>
    @jabraham17
    jabraham17 committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    06ba964 View commit details
    Browse the repository at this point in the history

  10. make sure files get renamed 

    Signed-off-by: Jade Abraham <[email protected]>
    @jabraham17
    jabraham17 committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    dd97b76 View commit details
    Browse the repository at this point in the history

  11. fix broken tests 

    Signed-off-by: Jade Abraham <[email protected]>
    @jabraham17
    jabraham17 committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    4702d98 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. update .good file for divexact 

    Signed-off-by: Jade Abraham <[email protected]>
    @jabraham17
    jabraham17 committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    cdde8f2 View commit details
    Browse the repository at this point in the history

  2. fix typo in new deprecation for div_q 

    Signed-off-by: Jade Abraham <[email protected]>
    @jabraham17
    jabraham17 committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    8d9af8d View commit details
    Browse the repository at this point in the history

  3. update deprecation message for div_q to better point to new proc 

    Signed-off-by: Jade Abraham <[email protected]>
    @jabraham17
    jabraham17 committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    ff7059c View commit details
    Browse the repository at this point in the history

  4. add note on enum to chpldoc doc 

    Signed-off-by: Jade Abraham <[email protected]>
    @jabraham17
    jabraham17 committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    c4b5266 View commit details
    Browse the repository at this point in the history

  5. fix .good files 

    Signed-off-by: Jade Abraham <[email protected]>
    @jabraham17
    jabraham17 committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    327c2b5 View commit details
    Browse the repository at this point in the history

  6. cleanup bigint documentation 

    Signed-off-by: Jade Abraham <[email protected]>
    @jabraham17
    jabraham17 committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    f150495 View commit details
    Browse the repository at this point in the history

  7. cleanup code in response to reviews 

    Signed-off-by: Jade Abraham <[email protected]>
    @jabraham17
    jabraham17 committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    3e75e56 View commit details
    Browse the repository at this point in the history

  8. cleanup spaces between functions in bigint 

    Signed-off-by: Jade Abraham <[email protected]>
    @jabraham17
    jabraham17 committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    ca4c8a3 View commit details
    Browse the repository at this point in the history