-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Marking Range and Domain Transformation Functions as Unstable #22765
Merged
ShreyasKhandekar
merged 9 commits into
chapel-lang:main
from
ShreyasKhandekar:range-transformation-unstable
Jul 19, 2023
Merged
Marking Range and Domain Transformation Functions as Unstable #22765
ShreyasKhandekar
merged 9 commits into
chapel-lang:main
from
ShreyasKhandekar:range-transformation-unstable
Jul 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShreyasKhandekar
force-pushed
the
range-transformation-unstable
branch
from
July 18, 2023 22:16
739b527
to
9987800
Compare
Signed-off-by: Shreyas Khandekar <[email protected]>
Signed-off-by: Shreyas Khandekar <[email protected]>
Signed-off-by: Shreyas Khandekar <[email protected]>
Signed-off-by: Shreyas Khandekar <[email protected]>
…ther test fixes Signed-off-by: Shreyas Khandekar <[email protected]>
Signed-off-by: Shreyas Khandekar <[email protected]>
Signed-off-by: Shreyas Khandekar <[email protected]>
Signed-off-by: Shreyas Khandekar <[email protected]>
Signed-off-by: Shreyas Khandekar <[email protected]>
ShreyasKhandekar
force-pushed
the
range-transformation-unstable
branch
from
July 19, 2023 19:07
01a1dc8
to
0af507c
Compare
vasslitvinov
approved these changes
Jul 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
This was referenced Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR marks the following functions on
range
anddomain
as unstable:translate
interior
exterior
expand
offset
(range only)indexOrder
(range only; the domain version has not been user-facing)orderToIndex
Marking these unstable until we resolve the design discussions on #17127 and #14884.