Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use $CHPL_HOME in locations printed from frontend errors #22757

Merged
merged 2 commits into from
Jul 17, 2023

Conversation

mppf
Copy link
Member

@mppf mppf commented Jul 17, 2023

Resolves #22752

This PR adjusts frontend/ error message printing to use $CHPL_HOME as the start of the path instead of its value. This avoids inconsistencies depending on whether the error is coming from frontend/ or the older production compiler code in compiler/.

Reviewed by @DanilaFe - thanks!

  • full comm=none testing

mppf added 2 commits July 17, 2023 15:21
---
Signed-off-by: Michael Ferguson <[email protected]>
Copy link
Contributor

@DanilaFe DanilaFe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mppf mppf merged commit 6ac2d60 into chapel-lang:main Jul 17, 2023
7 checks passed
@mppf mppf deleted the dyno-chpl-home-locs branch July 17, 2023 19:54
vasslitvinov added a commit to vasslitvinov/chapel that referenced this pull request Jul 19, 2023
@vasslitvinov vasslitvinov mentioned this pull request Jul 19, 2023
vasslitvinov added a commit that referenced this pull request Jul 19, 2023
This marks the type `dmap` as unstable, as discussed in a design subteam
on May 30.

While there, simplify test/compflags/TestWarnUnstableSuppression.prediff
and remove test/unstable-keyword/in-function.prediff, thanks to #22757.

r: @jabraham17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to convert the path $CHPL_HOME to the string '$CHPL_HOME'
2 participants