Fix broken tests for new cpu-as-device nightly test #22740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- Signed-off-by: Andy Stone <[email protected]>
e-kayrakli
approved these changes
Jul 13, 2023
| @@ -1,3 +1,4 @@ | |||
| #!/bin/sh | |||
|
|
|||
| sed -i -e 's/0x.*/0xPREDIFFED/' $2 | |||
| sed -i -e '/<internal>/d' $2 | |||
There was a problem hiding this comment.
Are these indeterministic calls stuff to worry about? Do you have a guess?
There was a problem hiding this comment.
[Saw your message on slack]. It looks like "tasking layer unspecified" allocations come from qthread's internal allocations. That's as far as I am willing to investigate, and I'm fine with filtering them for the time being.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a couple of failures in our new nightly test job for cpu-as-device for GPU support.
This PR modifies these tests so that they will no longer fail in this job.
transpose.chpl: is something we should be .skip'ifing for this job (I'll submit a followup PR to do that).
basicMem.chpl: It looks like we have some non-deterministic allocations in internal module code. This isn't really what the test is trying to lock down so it seems like we should just filter these messages out.