Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ChplConfig.compiledForSingleLocale() query #22730

Merged
merged 6 commits into from
Jul 20, 2023

Conversation

riftEmber
Copy link
Member

@riftEmber riftEmber commented Jul 12, 2023

Adds the compiledForSingleLocale() query to the ChplConfig module, which return true if the program is being compiled for a single locale.

This result is controlled by the --[no-]local flag, and if that is not present then by CHPL_COMM. The output of the query is identical to the compiler-provided _local variable, and many uses of _local in modules are replaced by the query in this PR.

Resolves https://github.com/Cray/chapel-private/issues/5019.

[reviewer info placeholder]

Testing:

  • local paratest
  • gasnet paratest
  • tests pass (and skip as appropriate) for all combinations of CHPL_COMM and --[no-]local

@riftEmber riftEmber force-pushed the compiledforsinglelocale-query branch 2 times, most recently from 46663dc to 4b35d59 Compare July 19, 2023 15:15
Copy link
Contributor

@jeremiah-corrado jeremiah-corrado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@riftEmber riftEmber force-pushed the compiledforsinglelocale-query branch 2 times, most recently from 3ca9784 to 4b4ae07 Compare July 20, 2023 16:03
@riftEmber riftEmber force-pushed the compiledforsinglelocale-query branch from 4b4ae07 to 296fad3 Compare July 20, 2023 16:30
@riftEmber riftEmber merged commit 9b1d3db into chapel-lang:main Jul 20, 2023
7 checks passed
@riftEmber riftEmber deleted the compiledforsinglelocale-query branch July 20, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants