Dyno: field type resolution using only type expression #22706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates resolution of NamedDecls to check if we are currently trying to only resolve field types, and if so will try to only use an existing type expression. If that type expression resolves to be non-generic, then we will skip resolving an initialization expression. Signed-off-by: Ben Harshbarger <[email protected]>
Signed-off-by: Ben Harshbarger <[email protected]>
Signed-off-by: Ben Harshbarger <[email protected]>
mppf
approved these changes
Jul 10, 2023
Signed-off-by: Ben Harshbarger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves a bug in the dyno compiler where compilation could recurse through a field type's initialization expression, despite that field having a concrete type expression.
This PR adds a new field to
ResolvernamedfieldTypesOnly. This field is set in the cases where we are creating aResolverfor the purpose of resolving a type's fields. When this property is set, resolution of aNamedDeclwill check if it is the field being resolved, and if so, will attempt to only use the field's type expression (if one is available). If the type expression is not a concrete type, then resolution will proceed to resolve the field's initialization expression.This property does not apply to
typeorparamfields since the initialization expression is necessary in those cases (if one exists).A minor fix is included in this PR, in which we return from
resolveFnCallSpecialTypeif the special call is trying to be resolved as a method call (which is not valid Chapel).Future work involves updating the initializer implementation to take responsibility for checking the compatibility of field type expressions and initialization expressions (e.g. "var x : int = "hello";).
Testing: