Skip to content

Commit

Permalink
Change wording of multi-locale informational message (#22460)
Browse files Browse the repository at this point in the history
Change the wording of the multi-locale informational message from the
form

    executing on node 8 of 10 node(s): amd-0005

to the form

    executing locale 8 of 10 on node 'amd-0005'

to make the distinction between locales and nodes clearer.

[Reviewed by @ronawho, thank you.]
  • Loading branch information
jhh67 authored Jul 26, 2023
2 parents 98f9c70 + 8578291 commit 8a30ebf
Show file tree
Hide file tree
Showing 11 changed files with 11 additions and 11 deletions.
2 changes: 1 addition & 1 deletion runtime/src/comm/gasnet/comm-gasnet.c
Original file line number Diff line number Diff line change
Expand Up @@ -965,7 +965,7 @@ void chpl_comm_rollcall(void) {
// Initialize diags
chpl_comm_diags_init();

chpl_msg(2, "executing on node %d of %d node(s): %s\n", chpl_nodeID,
chpl_msg(2, "executing locale %d of %d on node '%s'\n", chpl_nodeID,
chpl_numNodes, chpl_nodeName());
}

Expand Down
2 changes: 1 addition & 1 deletion runtime/src/comm/ofi/comm-ofi.c
Original file line number Diff line number Diff line change
Expand Up @@ -3112,7 +3112,7 @@ void chpl_comm_rollcall(void) {
// Initialize diags
chpl_comm_diags_init();

chpl_msg(2, "executing on node %d of %d node(s): %s\n", chpl_nodeID,
chpl_msg(2, "executing locale %d of %d on node '%s'\n", chpl_nodeID,
chpl_numNodes, chpl_nodeName());

//
Expand Down
2 changes: 1 addition & 1 deletion runtime/src/comm/ugni/comm-ugni.c
Original file line number Diff line number Diff line change
Expand Up @@ -3009,7 +3009,7 @@ void chpl_comm_rollcall(void)
// Initialize diags
chpl_comm_diags_init();

chpl_msg(2, "executing on node %d of %d node(s): %s\n", chpl_nodeID,
chpl_msg(2, "executing locale %d of %d on node '%s'\n", chpl_nodeID,
chpl_numNodes, chpl_nodeName());

if (chpl_numNodes == 1)
Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1 @@
executing on node 0 of 1 node(s): UNAME
executing locale 0 of 1 on node 'UNAME'
Original file line number Diff line number Diff line change
@@ -1 +1 @@
executing on node 0 of 1 node(s): UNAME
executing locale 0 of 1 on node 'UNAME'
Original file line number Diff line number Diff line change
@@ -1 +1 @@
executing on node 0 of 1 node(s): UNAME
executing locale 0 of 1 on node 'UNAME'
2 changes: 1 addition & 1 deletion test/multilocale/numLocales/bradc/testVFlag.prediff
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ fi
# aren't meaningful.
case $target in
cray-cs|cray-x*|hpe-cray-ex)
sed "s/\(executing on node 0 of 1 node(s): \).*/\1$uname/" \
sed "s/\(executing locale 0 of 1 on node \).*/\1'$uname'/" \
< $2 > $2.tmp &&
mv $2.tmp $2;;
esac
Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1 @@
executing on node 0 of 1 node(s): UNAME
executing locale 0 of 1 on node 'UNAME'
Original file line number Diff line number Diff line change
@@ -1 +1 @@
executing on node 0 of 1 node(s): UNAME
executing locale 0 of 1 on node 'UNAME'
Original file line number Diff line number Diff line change
@@ -1 +1 @@
executing on node 0 of 1 node(s): UNAME
executing locale 0 of 1 on node 'UNAME'
2 changes: 1 addition & 1 deletion test/multilocale/numLocales/bradc/testVerboseFlag.prediff
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ fi
# aren't meaningful.
case $target in
cray-cs|cray-x*|hpe-cray-ex)
sed "s/\(executing on node 0 of 1 node(s): \).*/\1$uname/" \
sed "s/\(executing locale 0 of 1 on node \).*/\1'$uname'/" \
< $2 > $2.tmp &&
mv $2.tmp $2;;
esac
Expand Down

0 comments on commit 8a30ebf

Please sign in to comment.