docs: docs for UDS data client/server #57
Conversation
Signed-off-by: STRRL <[email protected]>
|
But I am still curious that, I see there is nowhere to close the uds connection / |
Mio will close it automatically. |
Any reference? ❤️ |
Everything base on unix fd all drop here. It is really hard to trace. https://stdrs.dev/nightly/x86_64-unknown-linux-gnu/src/std/os/fd/owned.rs.html#167 |
| /// child, once the client connect, it would send the serialized data to the client immediately. | ||
| /// | ||
| /// It would block the current thread, so it's recommended to call this method in a new thread. | ||
| /// TODO(@STRRL): graceful shutdown is not supported yet |
There was a problem hiding this comment.
TODO(@STRRL): graceful shutdown is not supported yet
UDS will automatic shutdown here. IMO, we do not need graceful shutdown here.
There was a problem hiding this comment.
UDS will automatic shutdown here. IMO, we do not need graceful shutdown here.
It seems the UDS server would not be reused between multiple Proxy::reload(), and it would keep aceept() inside the infinite loop, and the listener already moved into the inner scope, there is nowhere to "drop" it.
If I am correct, that's a resource leak.
There was a problem hiding this comment.
I found it. It truely leaks. I agree with you . But this is not problem here. We will not meet leak only with UDS server . We leak because we spawn a blocking server.
Signed-off-by: STRRL [email protected]
append some docs for UDS part