-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: verify lockfile on PR, commit on push to main #877
chore: verify lockfile on PR, commit on push to main #877
Conversation
This might not be correct, I want to verify it actually throws an error if the lockfile is incorrect before merge |
.github/workflows/Lockfile.yml
Outdated
@@ -1,6 +1,9 @@ | |||
name: Lockfile | |||
on: | |||
pull_request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should remove "pull_request" here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we separate it into two workflows, one that commits a new lockfile on push to main, and one that verifies that the PR has a correct lockfile (and could commit a new one to the source branch if the PR is this repo).
We then technically do it twice and the one that runs on pushes to main would be a safety if something would get merged without an updated lockfile.
Or skip validation of the lockfile on PRs and simply update it on every push to main?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we separate it into two workflows
yes, completely, that would be much cleaner. and the modification one would be removed once renovate will be able to update both the pom and the lockfile at the same time.
… indicates the lcokfile is faulty.
…ks-contributors' of github.com:chains-project/maven-lockfile into 875-update-ci-so-that-it-works-for-pr-from-external-forks-contributors
… and pushes to main
… indicates the lcokfile is faulty.
89901f7
to
6b88db8
Compare
…ks-contributors' of github.com:chains-project/maven-lockfile into 875-update-ci-so-that-it-works-for-pr-from-external-forks-contributors
No description provided.