Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add includeEnvironment parameter #870 #871

Merged
merged 4 commits into from
Sep 6, 2024

Conversation

massimeddu-sj
Copy link
Contributor

This PR introduce a new parameter includeEnvironment that by default is true.

@monperrus
Copy link
Contributor

Thanks for the PR, we'll look at it.

@monperrus
Copy link
Contributor

CI is failing?

@massimeddu-sj
Copy link
Contributor Author

CI is failing?

Apparently some tests are failing, but currently I'm not able to reproduce these failures on my local environment. I'll try to understand why they are failing and I'll try to fix them.

@massimeddu-sj
Copy link
Contributor Author

CI is failing?

I've fixed the failing tests and the formatting issues. Now it should be good.

@massimeddu-sj
Copy link
Contributor Author

I've rebased the PR to solve merge conflicts.

@LogFlames
Copy link
Member

Thank you for the PR!
Please take a look at my one comment, the rest of the code looks good.
I will also look into the ˋcheck-lockfileˋ action.

@massimeddu-sj
Copy link
Contributor Author

Thank you for the PR! Please take a look at my one comment, the rest of the code looks good. I will also look into the ˋcheck-lockfileˋ action.

Sorry, I cannot find your comment. Can you please link it or re-post here?

@LogFlames
Copy link
Member

Of course, here it is

@massimeddu-sj
Copy link
Contributor Author

Of course, here it is

I'm a bit confused, the link opens this same page. Maybe your comment is private or I don't have permissions to see it?

@LogFlames
Copy link
Member

LogFlames commented Sep 6, 2024

Yes you’re right, I hadn’t published the review. Now it should be visible!

@LogFlames LogFlames merged commit 83c1851 into chains-project:main Sep 6, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants