Disallow internet egress by default & reroute accounts.google.com -> private.googleapis.com #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tcnghia
commented
Apr 18, 2024
•
tcnghia
commented
- Disallow 0.0.0.0/0 egress
- Reroute accounts.google.com -> private.googleapis.com so that we can verify OIDC token of Cloud Run private service requests
Instead specify a specific range for Google APIs Signed-off-by: Nghia Tran <[email protected]>
Signed-off-by: Nghia Tran <[email protected]>
Signed-off-by: Nghia Tran <[email protected]>
mattmoor
reviewed
Apr 18, 2024
Signed-off-by: Nghia Tran <[email protected]>
tcnghia
commented
Apr 18, 2024
Signed-off-by: Nghia Tran <[email protected]>
k4leung4
approved these changes
Apr 26, 2024
|
@tcnghia what's left here? |
Nothing, this just slipped past my mind. Merging now. |
|
Actually, since this has been tested very long ago I'd run some more testing this week before merging. Don't wait for this PR to cut your release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.