Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MANTRA Mainnet and Testnet images and chain registrations #826

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

mantramatt
Copy link
Contributor

feat: add MANTRA Dukong Testnet and MANTRA-1 Mainnet registrations and logos

Copy link

vercel bot commented Oct 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keplr-chain-registry ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 2:26pm

@kamal-sutra
Copy link
Contributor

@mantramatt Please check the failed validations. I think the image url's are incorrect.

@mantramatt
Copy link
Contributor Author

Hi @kamal-sutra thanks for reviewing this for us. The images are actually in this PR. Do we need to host them externally on our CDN or is the preference to have them in this repository?

@kamal-sutra
Copy link
Contributor

kamal-sutra commented Oct 15, 2024

@mantramatt the image path is incorrect. please check the Details in the PR Validation checks which is not successful.
It is preferred to be in this repo but with correct path
https://github.com/chainapsis/keplr-chain-registry/actions/runs/11305734773/job/31445552305?pr=826

@mantramatt mantramatt marked this pull request as ready for review October 15, 2024 14:27
@blacktoast blacktoast merged commit eabdef8 into chainapsis:main Oct 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants