Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pryzm mainnet and update pryzm testnet #630

Closed
wants to merge 1 commit into from
Closed

Add pryzm mainnet and update pryzm testnet #630

wants to merge 1 commit into from

Conversation

arthuryeti
Copy link
Contributor

Hey guys :)

Let us know if something is wrong.

Thank you

@vercel Vercel
Copy link

vercel bot commented May 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keplr-chain-registry ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 11:53am

@editaahn
Copy link
Collaborator

editaahn commented May 17, 2024 •
edited
Loading

Hi! Since we merge PRs for registering Keplr-supported mainnet chains right before the launch time, if you need testnet changes to be merged ahead of time, please separate PRs for testnet and mainnet changes. Then, I'll merge the testnet changes right away.

@arthuryeti
Copy link
Contributor Author

@editaahn all good :) testnet can wait.

editaahn
editaahn reviewed May 20, 2024
View reviewed changes
cosmos/pryzm.json
"website": "https://pryzm.zone/"
},
"chainId": "pryzm-1",
"chainName": "pryzm",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intentional for the chain name to start with the lowercase letter?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just wondering whether it's fine for you!

@editaahn
Copy link
Collaborator

I write additional lines to your changes through the new PR below for the native chain support.
#633
I'll close this PR and we can continue our conversation and the whole progress on the new PR.

@editaahn editaahn closed this May 20, 2024
@editaahn editaahn mentioned this pull request May 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@editaahn editaahn editaahn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arthuryeti @editaahn