Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add amATOM token to neutron testnet #621

Merged
merged 3 commits into from
May 16, 2024
Merged

Conversation

sinplea
Copy link
Contributor

@sinplea sinplea commented May 15, 2024

This PR adds amATOM to neutron testnet (pion-1) currencies

Copy link

vercel bot commented May 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keplr-chain-registry ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 11:41pm

@editaahn
Copy link
Collaborator

editaahn commented May 16, 2024

Hi! Could you pull the current changes from this repo and then re-run the validation? A validation failure was discovered, which was caused by the existing Pion chain image URL. I fixed it shortly before.

cosmos/pion.json Outdated
"coinDenom": "amATOM",
"coinMinimalDenom": "factory/neutron15lku24mqhvy4v4gryrqs4662n9v9q4ux9tayn89cmdzldjcgawushxvm76/amatom",
"coinDecimals": 6,
"coinImageUrl": "https://raw.githubusercontent.com/chainapsis/keplr-chain-registry/main/images/neutron/factory/neutron15lku24mqhvy4v4gryrqs4662n9v9q4ux9tayn89cmdzldjcgawushxvm76/amATOM.png"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image directory should be pion instead of neutron

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed 👍

@editaahn editaahn merged commit ba229a9 into chainapsis:main May 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants