Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CUDOS chain to registry #260

Merged
merged 4 commits into from
Oct 19, 2023
Merged

Add CUDOS chain to registry #260

merged 4 commits into from
Oct 19, 2023

Conversation

olliegilbey
Copy link
Contributor

This PR adds the JSON and image files to the Keplr chain registry for the CUDOS chain

@vercel
Copy link

vercel bot commented Oct 16, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keplr-chain-registry ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2023 3:31pm

@HeesungB
Copy link
Collaborator

@olliegilbey Can you edit the file using the link below?
https://github.com/chainapsis/keplr-chain-registry#requirement-details

You can also use the command below to check the validation locally.

yarn validate cosmos/cudos.json

@olliegilbey
Reorder JSON Fields, add wallet, resize images
69e136f 
This commit reorders the fields to be in line with the requirements,
adds the wallet and staking url, and resizes the images to 256x256
pixels
@olliegilbey
Copy link
Contributor Author

@HeesungB , thanks for the quick response.
I should have opened this PR to main of our fork instead first, sorry about the noise!

Have committed again that should line things up better, the yarn validate passes with no errors and I've resized the images to 256 square pixels.

We are just checking the gas price values and will let you know when all is good.

Thanks again for the quick response here!

jgtormo
jgtormo reviewed Oct 16, 2023
View reviewed changes
cosmos/cudos.json Outdated Show resolved Hide resolved
@olliegilbey @jgtormo
Change low fee to match average
d7601eb 
Co-authored-by: Joan Garcia Tormo <[email protected]>
@HeesungB
Copy link
Collaborator

@olliegilbey @jgtormo Should i merge it?

@olliegilbey
Copy link
Contributor Author

@HeesungB , yes please, all good to go.
Thanks so much 🚀

@HeesungB HeesungB merged commit 68aa636 into chainapsis:main Oct 19, 2023
3 checks passed
@HeesungB
Copy link
Collaborator

@olliegilbey @jgtormo Thank you for contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgtormo jgtormo jgtormo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olliegilbey @HeesungB @jgtormo