Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Highbury_710-1 #241

Merged
merged 5 commits into from
Sep 19, 2023
Merged

Update Highbury_710-1 #241

merged 5 commits into from
Sep 19, 2023

Conversation

sudopunk
Copy link
Contributor

@sudopunk sudopunk commented Sep 19, 2023

@Thunnini
Config has been updated and validated locally. However, the wallet derivation path did not resolve as expected.
Please advise. We use the same coin type as kava (459).

@JeremyParish69 Your inputs in the matter are welcome too.

@vercel
Copy link

vercel bot commented Sep 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keplr-chain-registry ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2023 0:22am

@sudopunk
Copy link
Contributor Author

When I try to add the config to Cosmostation, the address derived seems to be working correctly. Any assistance in the matter would be received gratefully.

@HeesungB
Copy link
Collaborator

@sudopunk Could you remove this two(walletUrl, walletUrlForStaking ) field?
This is an invalid URL and is not needed now.

@HeesungB HeesungB merged commit 4ec8104 into chainapsis:main Sep 19, 2023
2 checks passed
@HeesungB
Copy link
Collaborator

@sudopunk I'm not sure about Cosmostation.
Could you please contact Cosmostation?

@sudopunk
Copy link
Contributor Author

@Thunnini Config has been updated and validated locally. However, the wallet derivation path did not resolve as expected. Please advise. We use the same coin type as kava (459).

@JeremyParish69 Your inputs in the matter are welcome too.

The address for the cointype 459 does not seem to appear correctly on Keplr.

@Thunnini
Copy link
Member

@sudopunk
Please read the readme before posting a PR.
First of all, this PR doesn't make sense. There was "eth-address-gen" in features, but why did it disappear later? In common sense, how can the address system change while the chain is in operation?

@HeesungB HeesungB mentioned this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants