Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add composable #212

Merged
merged 2 commits into from
Aug 17, 2023
Merged

Add composable #212

merged 2 commits into from
Aug 17, 2023

Conversation

hoangdv2429
Copy link
Contributor

This PR will add composable token.

@vercel
Copy link

vercel bot commented Aug 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keplr-chain-registry ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 17, 2023 9:22am

@hoangdv2429 hoangdv2429 marked this pull request as draft August 17, 2023 08:40
@hoangdv2429
Copy link
Contributor Author

need chain.png and ppica.png before review

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be cosmos/composable.json thanks!

Copy link
Contributor Author

@hoangdv2429 hoangdv2429 Aug 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried Composable. It will fail because fail name is deduct from chainId

@hoangdv2429 hoangdv2429 changed the title init add composable Add composable Aug 17, 2023
@hoangdv2429 hoangdv2429 marked this pull request as ready for review August 17, 2023 09:22
@hoangdv2429
Copy link
Contributor Author

@HeesungB Good morning, Can you review this PR ? Thank you

@HeesungB HeesungB merged commit 0348eaf into chainapsis:main Aug 17, 2023
2 checks passed
@HeesungB
Copy link
Collaborator

@hoangdv2429 @josietyleung I merged it.
Thank you for contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants