Remove pulsar.json #195
Merged
Remove pulsar.json #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`pulsar-2` is depreciated: `pulsar-3` info https://docs.scrt.network/secret-network-documentation/development/resources-api-contract-addresses/connecting-to-the-network/testnet-pulsar-3
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
the presence of pulsar breaks a the ability to suggest pulsar-3 if (pulsar-2 is defined here). Or the ability to suggest pulsar-2 (if pulsar-3 is defined here) https://github.com/chainapsis/keplr-wallet/blob/8ab00c015c12a274f7570f0aca7bb7c656f85230/packages/stores/src/core/interaction/chain-suggest.ts#L66
|
@luca992 How about keep the current file and change to |
As I was trying to say, people cannot suggest the |
|
@luca992 I got it! |
|
I would leave them if it were up to me. That way people can use them in their suggested configs. Also, once |
|
@luca992 I merge it. Thank you for contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The presence of pulsar breaks a the ability to suggest pulsar-3 if (pulsar-2 is defined here). Or the ability to suggest pulsar-2 (if pulsar-3 is defined here). Until pulsar-2 is taken down I don't think pulsar-2 or pulsar-3 should be defined here... unless a proper fix in keplr was implemented to make sure the chain ids actually match from the community repo to what the user supplied, and if not use what the person actually suggested.
https://github.com/chainapsis/keplr-wallet/blob/8ab00c015c12a274f7570f0aca7bb7c656f85230/packages/stores/src/core/interaction/chain-suggest.ts#L66