Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UnUniFi #158

Merged
merged 13 commits into from
Jul 28, 2023
Merged

Add UnUniFi #158

merged 13 commits into from
Jul 28, 2023

Conversation

Senna46
Copy link
Contributor

@Senna46 Senna46 commented Jun 15, 2023

Create a new entry for UnUniFi.
Website: https://ununifi.io/

Please review to merge it.
Our cosmos chain-registry is here https://github.com/cosmos/chain-registry/tree/master/ununifi

@vercel
Copy link

vercel bot commented Jun 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keplr-chain-registry ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 27, 2023 0:38am

@HeesungB
Copy link
Collaborator

@Senna46 Hello!
UnUniFI's chainIdentifier is ununifi-beta.
So Could you change name ununifito ununifi-beta and image directory name?

@Senna46
Copy link
Contributor Author

Senna46 commented Jun 15, 2023

@HeesungB The chainID is ununifi-beta-1, but it is the mainnet. It will be changed to ununifi-1 in a hard fork soon. (Because we can't change it with on-chain upgrades)

@HeesungB
Copy link
Collaborator

@Senna46 Ok. Could you mention after change?

@Senna46
Copy link
Contributor Author

Senna46 commented Jun 18, 2023

@HeesungB From what I have confirmed, the Chain ID change will be a while in the future.
We would like to merge with this content first. Will change Chain ID later.

@HeesungB
Copy link
Collaborator

@Senna46
Your chainIdentifier is ununifi-beta.
So Could you change name ununifito ununifi-beta and image directory name?

@Senna46
Copy link
Contributor Author

Senna46 commented Jun 21, 2023

Changed directory name
Is this OK?

@HeesungB
Copy link
Collaborator

@Senna46 Yes it is ok.
But, Could you rename cosmos/ununifi.json to cosmos/ununifi-beta.json?
and Could you remove coinGeckoIdfield about all currencies?
because GUU is not registered in coinGecko site.

@Senna46
Copy link
Contributor Author

Senna46 commented Jun 25, 2023

@HeesungB Changed. Now once we want to merge.
I will create a Pull Request again when the beta is removed.

"coinDenom": "GUU",
"coinMinimalDenom": "uguu",
"coinDecimals": 6,
"coinGeckoId": "ununifi",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Senna46 It should be removed

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coinGeckoId field.

@HeesungB
Copy link
Collaborator

@Senna46 Sorry. My bad.
Your chainIdentfier is ununifi-beta-v1 not ununifi-beta.
So Could you change file names?

@Senna46
Copy link
Contributor Author

Senna46 commented Jul 6, 2023

I've made the change, is that correct? @HeesungB

@HeesungB
Copy link
Collaborator

HeesungB commented Jul 6, 2023

@Senna46 Yes It is correct.
Could you add 'node provider' information?

@Senna46
Copy link
Contributor Author

Senna46 commented Jul 6, 2023

@HeesungB I added nodePrivider field

},
"chainId": "ununifi-beta-v1",
"chainName": "UnUniFi",
"chainSymbolImageUrl": "https://raw.githubusercontent.com/chainapsis/keplr-chain-registry/main/images/ununifi/chain.png",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Senna46
Link will be changed from ununifi/chain.png to ununifi-beta-v1/chain.png

"coinDenom": "GUU",
"coinMinimalDenom": "uguu",
"coinDecimals": 6,
"coinImageUrl": "https://raw.githubusercontent.com/chainapsis/keplr-chain-registry/main/images/ununifi/uguu.png"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"coinDenom": "GUU",
"coinMinimalDenom": "uguu",
"coinDecimals": 6,
"coinImageUrl": "https://raw.githubusercontent.com/chainapsis/keplr-chain-registry/main/images/ununifi-beta/uguu.png"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"coinDenom": "GUU",
"coinMinimalDenom": "uguu",
"coinDecimals": 6,
"coinImageUrl": "https://raw.githubusercontent.com/chainapsis/keplr-chain-registry/main/images/ununifi-beta/uguu.png",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Senna46
Copy link
Contributor Author

Senna46 commented Jul 25, 2023

I fixed image link. @HeesungB

"coinDenom": "GUU",
"coinMinimalDenom": "uguu",
"coinDecimals": 6,
"coinGeckoId": "ununifi",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Senna46 Could you remove coinGeckoId field?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed. I forgot.

@HeesungB HeesungB merged commit 608e9dd into chainapsis:main Jul 28, 2023
1 check passed
@HeesungB
Copy link
Collaborator

@Senna46 Thank you for contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants