Skip to content

Commit

Permalink
manifest: drop containernetworking-plugins and podman-plugins
Browse files Browse the repository at this point in the history
Since podman is dropping support for CNI networking entirely
we can drop containernetworking-plugins and  podman-plugins.
Podman stopped shipping podman-plugins rpm with the Podmanv5.
Subsequently, we wouldn't need containernetworking-plugins as
it is just libraries for writing CNI plugins.
  • Loading branch information
gursewak1997 authored and dustymabe committed Feb 13, 2024
1 parent 533a824 commit 6f073a2
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 4 deletions.
5 changes: 5 additions & 0 deletions manifests/cni-plugins.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# Issue: https://github.com/coreos/fedora-coreos-config/pull/2818
# Delete this file once we are on Podman v5 everywhere.
# i.e. We have moved past F39.
packages:
- containernetworking-plugins podman-plugins
7 changes: 3 additions & 4 deletions manifests/fedora-coreos-base.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -104,11 +104,10 @@ packages:
# Containers
- systemd-container catatonit
- fuse-overlayfs slirp4netns
# support for old style CNI networks and name resolution for
# podman containers with CNI networks
# Some host applications(i.e. NetworkManager) use dnsmasq
# as the binary for some various utility operations.
# https://github.com/coreos/fedora-coreos-tracker/issues/519
# https://github.com/coreos/fedora-coreos-tracker/issues/1128#issuecomment-1071338097
- containernetworking-plugins podman-plugins dnsmasq
- dnsmasq
# For podman v4 netavark gets pulled in but it only recommends
# aardvark-dns (which provides name resolution based on container
# names). This functionality was previously provided by dnsname from
Expand Down
6 changes: 6 additions & 0 deletions manifests/fedora-coreos.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,12 @@ conditional-include:
# passwd RPM was obsoleted by shadow-utils in F40+, but we need to keep
# including it in F39. Remove this when we are on F40+ on all streams.
include: passwd.yaml
- if: releasever == 39
# No longer need CNI plugins in f40 since Podman dropped
# support for CNI networking entirely in Podmanv5
# Remove this once we have Podman v5 in f39.
# xref: https://github.com/coreos/fedora-coreos-tracker/issues/1629
include: cni-plugins.yaml

ostree-layers:
- overlay/15fcos
Expand Down

0 comments on commit 6f073a2

Please sign in to comment.