-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use duck typing and exceptions as well as spaces instead of tabs #40
base: master
Are you sure you want to change the base?
Conversation
jihoon796
commented
Dec 28, 2015
from urllib import urlencode | ||
from urllib2 import Request, urlopen | ||
import datetime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i believe it should be alphabetical by module name.. so:
import datetime
from urllib import urlencode
from urllib2 import Request, urlopen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, fixed now - thanks!
On Sun, Dec 27, 2015 at 11:23 PM, Corey Goldberg [email protected]
wrote:
In ystockquote.py
#40 (comment):from urllib import urlencode
- from urllib2 import Request, urlopen
- import datetime
i believe it should be alphabetical by module name.. so:
import datetime
from urllib import urlencode
from urllib2 import Request, urlopen—
Reply to this email directly or view it on GitHub
https://github.com/cgoldberg/ystockquote/pull/40/files#r48462722.
from urllib import urlencode | ||
from urllib2 import Request, urlopen | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup.. thanks for that.
Hey Corey, please merge if everything looks good - otherwise, let me know. |