Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: notify aria-labelledby element id (fixes #152) #153

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Fix: notify aria-labelledby element id (fixes #152) #153

merged 1 commit into from
Nov 4, 2024

Conversation

kirsty-hames
Copy link
Contributor

Fixes #152

Fix

  • Changed 'notify-heading' to id from class such that the aria-labelledby on the dialog can find the element

@kirsty-hames kirsty-hames self-assigned this Nov 4, 2024
@oliverfoster oliverfoster merged commit 1be4cb6 into master Nov 4, 2024
1 check passed
@oliverfoster oliverfoster deleted the issue/152 branch November 4, 2024 13:00
github-actions bot pushed a commit that referenced this pull request Nov 4, 2024
@semantic-release-bot
Chore(release): 4.6.1 [skip ci]
c81a006 
## [4.6.1](v4.6.0...v4.6.1) (2024-11-04)

### fix

* Bump braces from 3.0.2 to 3.0.3 (#151) ([789262e](789262e)), closes [#151](#151)

### Fix

* notify aria-labelledby element id (fixes #152) (#153) ([1be4cb6](1be4cb6)), closes [#152](#152) [#153](#153)
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024

🎉 This PR is included in version 4.6.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverfoster oliverfoster oliverfoster approved these changes

Assignees

@kirsty-hames kirsty-hames

Labels
accessibility bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Popup 'notify-heading' should be an id not a class
2 participants
@kirsty-hames @oliverfoster