-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENT-11853: Adjusted calling pg_upgrade during upgrade to include LD_LIBRARY_PATH of previous installation #1463
Conversation
upgrade from 3.18.7 to 3.24.0a package built by jenkins worked with pg_upgrade, no mention of "cannot execute" for So I think this is a good change. Let's try with more platforms |
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/10964/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-10964/ |
Before running through all platforms I needed to remove the workaround we had in place to skip presenting the log which might have had "cannot execute" for some platforms. @cf-bottom I am now ready for jenkins to test this change |
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/10965/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-10965/ |
@cf-bottom jenkins, go ahead, I cancelled the last one because I was considering using LD_PRELOAD instead of LD_LIBRARY_PATH but I think LD_LIBRARY_PATH is better. Either one of them can fail if the loader is in secure-execution mode (see man ld.so) but so far on one platform, debian-12, this was not the case and LD_LIBRARY_PATH did the trick and allowed pg_upgrade and postgres to execute with the old libssl1.1 and libcrypto1.1 libraries when newer versions were present in /var/cfengine/lib and would have cause a "cannot execute" to occur. |
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/10966/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-10966/ |
@cf-bottom jenkins please, all platforms is ideal with deployment tests to check upgrades and such. |
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/10987/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-10987/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Instead of running CI/jenkins again, I'll just test the build that exists on the platforms I removed from exceptions. 👍 and then merge when I am satisfied. |
… of previous installation pg_upgrade calls postgres which includes reference to libssl that may change during upgrade which will cause postgres to not be executable Add LD_LIBRARY_PATH=$BACKUP_DIR/lib/ to address this issue. Ticket: ENT-11853 Changelog: title
…l library version changes during upgrades Ticket: ENT-11853 Changelog: none
9ac67df
to
18049db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Thanks!
cherry picked to 3.21.x: #1476 |
pg_upgrade calls postgres which includes reference to libssl that may change during upgrade which will cause postgres to not be executable
Add LD_LIBRARY_PATH=$BACKUP_DIR/lib/ to address this issue.
Ticket: ENT-11853
Changelog: title