ENT-10647: Added safety for hub upgrade in packaging scriptlets #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
craigcomstock
commented
Sep 25, 2023
craigcomstock
commented
- Improved resilience of hub package installer in case of postgresql server errors
- Added better pg_upgrade failure handling in package install scripts
- Added safety around stopping postgresql server during upgrade
…rver errors A case was found where postgresql could not be started. Due to set -e being in effect the else condition if the start fails was not used when it should have been. Wrapped the region of script in a subshell without error handling Ticket: ENT-10647 Changelog: title
Try to print last lines of any log files that are appropriate. Day boundaries could affect this code but I didn't want to tail all the logs there if there were many. Ticket: ENT-10647 Changelog: title
Previously we executed pg_ctl stop (aka "Fast" stop) and assumed the server would be stopped immediately which is not guaranteed. Now wait up to 5 seconds for the server to stop. If it does not stop in that time, fail the package postinstall script. Ticket: ENT-10647 Changelog: title
craigcomstock
commented
Sep 25, 2023
|
need to use non-fork branch :p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.