Fix copy-paste-cut for Firefox and for any other browser that works the same way #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you press CTRL+C, CTRL+V on firefox, for some reason it doesn't send "paste" or "copy" events, but a "keyup" event with "v" or "c" keyCode with a ctrlKey modifier. With this fix everything gets handled how it should
| @@ -112,6 +112,23 @@ export class InputHandler { | |||
| return; | |||
| } | |||
|
|
|||
| //Copy/Cut, call the right methods | |||
| if(event.charCode == 118 && event.ctrlKey) | |||
There was a problem hiding this comment.
this could also be command key on mac, maybe you could fix it for mac also? this link might be helpful
https://developer.mozilla.org/en-US/docs/Web/API/MouseEvent/metaKey
|
Hi, @EmaGht: there's a fork of this project that has been initiated by user @christopheelkhoury (#121 (comment)). He's offered to work on some of the issues this project has, and has invited everyone with an open issue or pull request to re-issue them on his copy. If you're interested, please check out his repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #99