Add env variable support for configuration #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit also makes possible to use json files as configuration files via `viper` configuration library. And contains breaking changes to configuration. Because of viper's limitations of detecting new map keys from env variables, a little procedure goes trough prefixed env variables and override viper settings by the parsed value of them. If the configuration file is in yaml format env variables can contain correct yaml strings and they will be parsed correctly. This behaviour is same for json files too.
…nto upstream # Conflicts: # auth_server/authn/github_auth.go # auth_server/authn/ldap_auth.go # auth_server/authn/static_auth.go # auth_server/authz/acl_mongo.go # auth_server/main.go # auth_server/mgo_session/mgo_session.go # auth_server/server/config.go
|
Thanks for picking up this PR @ewassef As you can imaging this will take some time to review, especially due to the breaking nature, however I can commit to you (haha, no pun intended 😉) to review this. |
|
Thanks for the follow-up.. I went ahead and fixed the tests and committed the change. |
|
@techknowlogick would you mind letting the checks kick off so I can fix anything that might come up/ |
|
@techknowlogick any guidance? |
|
@flaper87 @techknowlogick @karmi anyone? |
|
Hi there @techknowlogick @umurgdk @karmi @flaper87 any help is appreciated |
|
I've just tried pushing an update to see if that fixed the build |
|
@techknowlogick any help? |
|
Is there any chance that it could be completed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#225 updated to current HEAD
The original author is @Um
Tagging @techknowlogick frm the other PR https://github.com/techknowlogick