fix: missing name in assets (#201)

Fixes #155

src/mappings/handlers/loansHandlers.ts

@@ -76,10 +76,8 @@ async function _handleLoanCreated(event: SubstrateEvent<LoanCreatedEvent>) {
   }
 
   await asset.updateAssetSpecs(assetSpecs)
-  await asset.updateIpfsAssetName().catch((err) => {
-    logger.error(`IPFS Request failed ${err}`)
-    return Promise.resolve()
-  })
+  await asset.updateItemMetadata()
+  await asset.updateIpfsAssetName()
   await asset.save()
 
   const epoch = await EpochService.getById(pool.id, pool.currentEpoch)
@@ -169,9 +167,6 @@ async function _handleLoanBorrowed(event: SubstrateEvent<LoanBorrowedEvent>): Pr
     await epoch.increaseBorrowings(amount)
     await epoch.save()
   }
-
-  await asset.updateItemMetadata()
-  await asset.updateIpfsAssetName().catch((err) => logger.error(`IPFS Request failed ${err}`))
   await asset.save()
 }
 
@@ -248,7 +243,6 @@ async function _handleLoanRepaid(event: SubstrateEvent<LoanRepaidEvent>) {
     await epoch.save()
   }
 
-  await asset.updateItemMetadata()
   await asset.save()
 }
 
@@ -259,7 +253,6 @@ async function _handleLoanWrittenOff(event: SubstrateEvent<LoanWrittenOffEvent>)
   const { percentage, penalty } = status
   const loan = await AssetService.getById(poolId.toString(), loanId.toString())
   await loan.writeOff(percentage.toBigInt(), penalty.toBigInt())
-  await loan.updateItemMetadata()
   await loan.save()
 
   const pool = await PoolService.getById(poolId.toString())
@@ -281,7 +274,6 @@ async function _handleLoanClosed(event: SubstrateEvent<LoanClosedEvent>) {
 
   const loan = await AssetService.getById(poolId.toString(), loanId.toString())
   await loan.close()
-  await loan.updateItemMetadata()
   await loan.save()
 
   const epoch = await EpochService.getById(pool.id, pool.currentEpoch)
@@ -356,7 +348,6 @@ async function _handleLoanDebtTransferred(event: SubstrateEvent<LoanDebtTransfer
       )
       await pool.increaseRealizedProfitFifo(realizedProfitFifo)
     }
-    await fromAsset.updateIpfsAssetName()
     await fromAsset.save()
 
     await pool.increaseRepayments(repaidPrincipalAmount, repaidInterestAmount, repaidUnscheduledAmount)
@@ -403,7 +394,6 @@ async function _handleLoanDebtTransferred(event: SubstrateEvent<LoanDebtTransfer
         settlementPrice.toBigInt()
       )
     }
-    await toAsset.updateIpfsAssetName()
     await toAsset.save()
 
     await pool.increaseBorrowings(borrowPrincipalAmount)
@@ -494,7 +484,6 @@ async function _handleLoanDebtTransferred1024(event: SubstrateEvent<LoanDebtTran
     await toAsset.activate()
     await toAsset.updateExternalAssetPricingFromState()
     await toAsset.borrow(amount)
-    await toAsset.updateIpfsAssetName()
     await toAsset.save()
 
     await pool.increaseBorrowings(amount)

src/mappings/services/assetService.ts

@@ -18,8 +18,7 @@ export class AssetService extends Asset {
     nftClassId: bigint | undefined,
     nftItemId: bigint | undefined,
     timestamp: Date,
-    blockchain = '0',
-    name?: string
+    blockchain = '0'
   ) {
     logger.info(`Initialising asset ${assetId} for pool ${poolId}`)
     const isActive = false
@@ -34,8 +33,6 @@ export class AssetService extends Asset {
       AssetStatus.CREATED
     )
 
-    asset.name = name
-
     asset.collateralNftClassId = nftClassId
     asset.collateralNftItemId = nftItemId
 
@@ -67,17 +64,18 @@ export class AssetService extends Asset {
   }
 
   static initOnchainCash(poolId: string, timestamp: Date) {
-    return this.init(
+    const asset = this.init(
       poolId,
       ONCHAIN_CASH_ASSET_ID,
       AssetType.OnchainCash,
       AssetValuationMethod.Cash,
       undefined,
       undefined,
       timestamp,
-      '0',
-      'Onchain reserve'
+      '0'
     )
+    asset.name = 'Onchain reserve'
+    return asset
   }
 
   static async getById(poolId: string, assetId: string) {
@@ -174,7 +172,6 @@ export class AssetService extends Asset {
 
     const payload = itemMetadata.unwrap()
     this.metadata = payload.data.toUtf8()
-
     return this
   }
 
@@ -193,14 +190,21 @@ export class AssetService extends Asset {
     return principal
   }
 
-  public async updateIpfsAssetName(): Promise<string | null> {
+  public async updateIpfsAssetName(): Promise<void> {
     logger.info(`Fetching IPFS asset name for asset ${this.id} `)
-    if (!this.metadata) return logger.warn('No IPFS metadata')
-    const metadata = await readIpfs<AssetIpfsMetadata>(this.metadata.match(cid)[0])
-    if (metadata?.name) {
-      this.name = metadata.name
+    if (!this.metadata){
+      logger.warn(`No metadata field set for asset ${this.id}`)
+      return
+    }
+    const metadata: AssetIpfsMetadata = await readIpfs<AssetIpfsMetadata>(this.metadata.match(cid)[0]).catch((err) => {
+      logger.error(`Request for metadata failed: ${err}`)
+      return undefined
+    })
+    if(!metadata) {
+      logger.error(`No http response from IPFS for asset id ${this.id} CID: ${this.metadata}`)
+      return
     }
-    return metadata?.name ?? null
+    this.name = metadata.name
   }
 
   public isOffchainCash() {