Fix/events (#86)

* Revert "Add ExtrinsicSignatureV5 (#68)"

This reverts commit 461cf42.

* Events fix

* fixes

* Fix DispatchError

* Fix tests

teste2e/author_submit_extrinsic_test.go

@@ -27,6 +27,47 @@ import (
 	"github.com/centrifuge/go-substrate-rpc-client/types"
 )
 
+func TestChain_Events(t *testing.T) {
+	targetURL := config.Default().RPCURL // Replace with desired endpoint
+	api, err := gsrpc.NewSubstrateAPI(targetURL)
+	if err != nil {
+		panic(err)
+	}
+
+	meta, err := api.RPC.State.GetMetadataLatest()
+	if err != nil {
+		panic(err)
+	}
+
+	key, err := types.CreateStorageKey(meta, "System", "Events", nil, nil)
+	if err != nil {
+		panic(err)
+	}
+
+	//fmt.Printf("%x\n", key)
+
+	blockNUmber := uint64(0) // Replace with desired block to parse events
+
+	bh, err := api.RPC.Chain.GetBlockHash(blockNUmber)
+	if err != nil {
+		panic(err)
+	}
+
+	raw, err := api.RPC.State.GetStorageRaw(key, bh)
+	if err != nil {
+		panic(err)
+	}
+
+	//fmt.Printf("%x\n", *raw)
+
+	events := types.EventRecords{}
+	err = types.EventRecordsRaw(*raw).DecodeEventRecords(meta, &events)
+	if err != nil {
+		panic(err)
+	}
+
+}
+
 func TestChain_SubmitExtrinsic(t *testing.T) {
 	if testing.Short() {
 		t.Skip("skipping end-to-end test in short mode.")

types/event_record.go

@@ -313,7 +313,10 @@ func (d *DispatchError) Decode(decoder scale.Decoder) error {
 		return err
 	}
 
-	if b == 1 {
+	// https://github.com/paritytech/substrate/blob/4da29261bfdc13057a425c1721aeb4ec68092d42/primitives/runtime/src/lib.rs
+	// Line 391
+	// Enum index 3 for Module Error
+	if b == 3 {
 		d.HasModule = true
 		err = decoder.Decode(&d.Module)
 	}
@@ -327,7 +330,7 @@ func (d *DispatchError) Decode(decoder scale.Decoder) error {
 func (d DispatchError) Encode(encoder scale.Encoder) error {
 	var err error
 	if d.HasModule {
-		err = encoder.PushByte(1)
+		err = encoder.PushByte(3)
 		if err != nil {
 			return err
 		}

types/event_record_test.go

@@ -239,7 +239,7 @@ func TestEventRecordsRaw_Decode(t *testing.T) {
 
 			"0002000000" + // ApplyExtrinsic(2)
 			"0001" + // System_ExtrinsicFailed
-			"01" + // HasModule
+			"03" + // HasModule
 			"0b" + // Module
 			"00" + // Error
 			"10270000" + // Weight

types/events.go

@@ -792,16 +792,17 @@ type EventUtilityBatchCompleted struct {
 // EventUtilityNewMultisig is emitted when a new multisig operation has begun.
 // First param is the account that is approving, second is the multisig account, third is hash of the call.
 type EventUtilityNewMultisig struct {
-	Phase    Phase
-	Who, ID  AccountID
-	CallHash Hash
-	Topics   []Hash
+	Phase   Phase
+	Who, ID AccountID
+	// TODO Get CallHash back on for newer versions of substrate
+	//CallHash Hash
+	Topics []Hash
 }
 
 // TimePoint is a global extrinsic index, formed as the extrinsic index within a block,
 // together with that block's height.
 type TimePoint struct {
-	Height BlockNumber
+	Height U32
 	Index  U32
 }
 
@@ -812,8 +813,9 @@ type EventUtilityMultisigApproval struct {
 	Who       AccountID
 	TimePoint TimePoint
 	ID        AccountID
-	CallHash  Hash
-	Topics    []Hash
+	// TODO Get CallHash back on for newer versions of substrate
+	//CallHash  Hash
+	Topics []Hash
 }
 
 // DispatchResult can be returned from dispatchable functions
@@ -857,9 +859,10 @@ type EventUtilityMultisigExecuted struct {
 	Who       AccountID
 	TimePoint TimePoint
 	ID        AccountID
-	CallHash  Hash
-	Result    DispatchResult
-	Topics    []Hash
+	// TODO Get CallHash back on for newer versions of substrate
+	//CallHash  Hash
+	Result DispatchResult
+	Topics []Hash
 }
 
 // EventUtility is emitted when a multisig operation has been cancelled. First param is the account that is
@@ -869,6 +872,7 @@ type EventUtilityMultisigCancelled struct {
 	Who       AccountID
 	TimePoint TimePoint
 	ID        AccountID
-	CallHash  Hash
-	Topics    []Hash
+	// TODO Get CallHash back on for newer versions of substrate
+	//CallHash  Hash
+	Topics []Hash
 }

types/events_test.go

@@ -40,7 +40,7 @@ func TestDispatchResult_Decode(t *testing.T) {
 	assert.True(t, res.Ok)
 
 	// Dispatch Error
-	decoder = scale.NewDecoder(bytes.NewReader([]byte{1, 1, 1, 1}))
+	decoder = scale.NewDecoder(bytes.NewReader([]byte{1, 3, 1, 1}))
 	res = DispatchResult{}
 	assert.NoError(t, decoder.Decode(&res))
 	assert.False(t, res.Ok)
@@ -49,7 +49,7 @@ func TestDispatchResult_Decode(t *testing.T) {
 	assert.Equal(t, res.Error.Error, byte(1))
 
 	// decoder error
-	decoder = scale.NewDecoder(bytes.NewReader([]byte{1, 1, 1}))
+	decoder = scale.NewDecoder(bytes.NewReader([]byte{1, 3, 1}))
 	res = DispatchResult{}
 	assert.Error(t, decoder.Decode(&res))
 }