Token Transfers MVP #2443
Merged
Token Transfers MVP #2443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR deployed in Google Cloud |
|
PR deployed in Google Cloud |
sophialittlejohn
approved these changes
Sep 13, 2024
| @@ -31,7 +31,7 @@ export function useActiveDomains(poolId: string, suspense?: boolean) { | |||
| const manager = await cent.liquidityPools.getManagerFromRouter([r.router], { | |||
| rpcProvider, | |||
| }) | |||
| const pool = await cent.liquidityPools.getPool([r.chainId, manager, poolId], { rpcProvider }) | |||
| const pool = await cent.liquidityPools.getPool([r.chainId, manager, poolId!], { rpcProvider }) | |||
There was a problem hiding this comment.
why not just throw an error if the poolId doesn't exist? Seems odd to mark it as optional and then force it here
There was a problem hiding this comment.
the query is only enabled when the poolId is set, a few lines down. So this is only called when there's a poolId. Only typescript doesn't get that. Adding checks and throwing instead of the assertion would just add noise IMO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#2408
Approvals
Screenshots
Impact