Hotfix: Add cursor based pagination for asset transactions #2438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR deployed in Google Cloud |
|
PR deployed in Google Cloud |
sophialittlejohn
added a commit
that referenced
this pull request
Sep 9, 2024
* Hotfix: finance form validation, subql self hosted, withdraw batch fix (#2436) * Point subquery to new version * Fix pending NAV calc * Fix mistake in subquery urls * Fix withdraw address validation * Include withdraw batch only where necessary * Undo accidental commit * Revalidate forms when source changes * Add cursor based pagination for asset transactions (#2438)
sophialittlejohn
added a commit
that referenced
this pull request
Sep 11, 2024
* Hotfix: finance form validation, subql self hosted, withdraw batch fix (#2436) * Point subquery to new version * Fix pending NAV calc * Fix mistake in subquery urls * Fix withdraw address validation * Include withdraw batch only where necessary * Undo accidental commit * Revalidate forms when source changes * Add cursor based pagination for asset transactions (#2438) * Hotfix: Nav Management dynamic Card (#2441) * Make change asset in asset valuation dynamic * Fix nav management card value in Drawer (#2442) * wip: try fixing values * wip: try fixing build * wip: try fixing number conversion * fix errors * wip: make numbers correct * Align nav managment tables on page and drawer --------- Co-authored-by: Onno Visser <[email protected]> Co-authored-by: sophian <[email protected]> --------- Co-authored-by: Frederik Gartenmeister <[email protected]> Co-authored-by: Onno Visser <[email protected]> --------- Co-authored-by: Frederik Gartenmeister <[email protected]> Co-authored-by: Onno Visser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request...
With the new instance of subquery a hard limit has been implemented on the server side and the query does not return more than 100 items at once. This PR implements cursor based pagination just in the SDK so that we don't have to build pagination on the UI.
Approvals
Screenshots
Impact