Add new card design to pools #2413
Conversation
|
PR deployed in Google Cloud |
|
PR deployed in Google Cloud |
kattylucy
force-pushed
the
add_tile_design
branch
2 times, most recently
from
6687e92
to
39e7e16
Compare
kattylucy
force-pushed
the
add_tile_design
branch
4 times, most recently
from
a02e33b
to
7273884
Compare
kattylucy
force-pushed
the
pool_overview_page_redesign
branch
2 times, most recently
from
a79a77a
to
c7d9d5e
Compare
kattylucy
force-pushed
the
add_tile_design
branch
7 times, most recently
from
0407c73
to
a317de5
Compare
kattylucy
force-pushed
the
add_tile_design
branch
2 times, most recently
from
3e3994d
to
bc878fb
Compare
| </TextWithPlaceholder> | ||
| return ( | ||
| <Card | ||
| marginRight={20} |
There was a problem hiding this comment.
this should be marked as an anchor tag for better semantics HTML. Should be as simple as as={a}, you'll probably still have to remove the default styling on the a tag.
| <Text as="span" variant="body3" color="textButtonPrimaryDisabled"> | ||
| Min Investment | ||
| </Text> | ||
| {tranchesData?.map((tranche) => renderText(`${tranche.minInvestment}`))} |
There was a problem hiding this comment.
This looked too big in the preview, I think you need to convert it to decimal first
| <StyledCard | ||
| marginRight={20} | ||
| marginBottom={20} | ||
| onClick={() => navigate(`/pools/${poolId}`)} |
There was a problem hiding this comment.
Better would be to use a React Router Link instead. That'll render it as an a too, but with an href for better usability.
kattylucy
force-pushed
the
add_tile_design
branch
from
d77e883
to
65ab1db
Compare
#2391