Styled components upgrade #2397
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
kattylucy
force-pushed
the
styled_components_upgrade
branch
from
b942069
to
fe4d546
Compare
kattylucy
requested review from
onnovisser and
sophialittlejohn
and removed request for
onnovisser
|
PR deployed in Google Cloud |
|
PR deployed in Google Cloud |
kattylucy
force-pushed
the
styled_components_upgrade
branch
from
fe4d546
to
c0a7232
Compare
sophialittlejohn
approved these changes
Aug 26, 2024
| ` | ||
|
|
||
| const StyledText = styled(Text)` | ||
| marginleft: auto; |
There was a problem hiding this comment.
Suggested change
| marginleft: auto; | |
| margin-left: auto; |
| @@ -27,10 +27,10 @@ const Chip = styled(Text)((props) => | |||
| css({ | |||
| display: 'inline-block', | |||
| px: 1, | |||
| bg: `${props.backgroundColor}Bg`, | |||
| bg: `${String(props.backgroundColor)}Bg`, | |||
There was a problem hiding this comment.
Suggested change
| bg: `${String(props.backgroundColor)}Bg`, | |
| bg: `${props.backgroundColor}Bg`, |
| borderRadius: 'chip', | ||
| whiteSpace: 'nowrap', | ||
| color: `${props.color}`, | ||
| color: `${String(props.color)}`, |
There was a problem hiding this comment.
Suggested change
| color: `${String(props.color)}`, | |
| color: `${props.color}`, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade styled components and fix the breaking changes
#2270
Approvals