Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finance form: Withdraw address select #2319

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Conversation

onnovisser
Copy link
Collaborator

@onnovisser onnovisser commented Jul 26, 2024

Description

  • Allow selecting the withdraw address in case there's multiple for a domain (or excluding a domain)
  • Include Centrifuge chain withdraw addresses for each domain

#2313

Approvals

  • Dev

Screenshots

image

Impact

Copy link

github-actions bot commented Jul 26, 2024

PR deployed in Google Cloud
URL: https://pr2319-app-ff-production.k-f.dev
Commit #: 6d2f9af
To access the functions directly check the corresponding deploy Action

Copy link

github-actions bot commented Jul 26, 2024

PR deployed in Google Cloud
URL: https://app-pr2319.k-f.dev
Commit #: 6d2f9af
To access the functions directly check the corresponding deploy Action

@sophialittlejohn
Copy link
Collaborator

@onnovisser do you have a pool I can test this with? I don't have LP enabled on any of mine

@onnovisser
Copy link
Collaborator Author

@sophialittlejohn if you run locally with the demo config, you can check this asset for example /issuer/729527817910/assets/2.

Copy link
Collaborator

@sophialittlejohn sophialittlejohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥

@onnovisser onnovisser enabled auto-merge (squash) August 2, 2024 08:10
@onnovisser onnovisser merged commit 8cefe43 into main Aug 2, 2024
10 checks passed
@onnovisser onnovisser deleted the withdraw-address-select branch August 2, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants