Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1 click debug pool creation #2215

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

1 click debug pool creation #2215

wants to merge 7 commits into from

Conversation

onnovisser
Copy link
Collaborator

@onnovisser onnovisser commented Jun 13, 2024

Description

Create a pool with 1 click from the debug panel. also adds a button to fund the accounts that are doing the pool creation/borrowing/investing etc.

  • create pool
  • Add asset originator and borrower hot wallet
  • Create asset template
  • Invest into the pool
  • Mint asset
  • Add fees
  • Feed oracle values
  • Close epoch
  • Finance asset
  • Repay asset

#2183

Approvals

  • Dev

Screenshots

Impact

Copy link

github-actions bot commented Jun 13, 2024

PR deployed in Google Cloud
URL: https://pr2215-app-ff-production.k-f.dev
Commit #: 4878969
To access the functions directly check the corresponding deploy Action

Copy link

github-actions bot commented Jun 13, 2024

PR deployed in Google Cloud
URL: https://app-pr2215.k-f.dev
Commit #: 4878969
To access the functions directly check the corresponding deploy Action

@onnovisser onnovisser marked this pull request as ready for review July 16, 2024 14:33
loanTemplates: [{ id: TEMPLATE_HASH, createdAt: new Date().toISOString() }],
}
const metadataInput: Partial<PoolMetadataInput> = {
poolName: 'E2E Test Pool',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be super helpful if we could somehow give each new pool a different name. What do you think about using a random name generator?

Copy link
Collaborator

@sophialittlejohn sophialittlejohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great first write! I like how you used the toasts to inform the user what stage we're on. I have a few suggestions how to improve the UX a bit:

  • add a number x/10 to the toasts (or how ever many txs there are) so we know how much long the process will be ongoing
  • some kind of feedback that the pool creation is finished - possibly a redirect to the new pool?
  • Generally after clicking the button we won't know which pool was just created so we need a way to communicate that - maybe with the redirect above or maybe with something else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants