-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1 click debug pool creation #2215
base: main
Are you sure you want to change the base?
Conversation
PR deployed in Google Cloud |
PR deployed in Google Cloud |
loanTemplates: [{ id: TEMPLATE_HASH, createdAt: new Date().toISOString() }], | ||
} | ||
const metadataInput: Partial<PoolMetadataInput> = { | ||
poolName: 'E2E Test Pool', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be super helpful if we could somehow give each new pool a different name. What do you think about using a random name generator?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great first write! I like how you used the toasts to inform the user what stage we're on. I have a few suggestions how to improve the UX a bit:
- add a number x/10 to the toasts (or how ever many txs there are) so we know how much long the process will be ongoing
- some kind of feedback that the pool creation is finished - possibly a redirect to the new pool?
- Generally after clicking the button we won't know which pool was just created so we need a way to communicate that - maybe with the redirect above or maybe with something else?
Description
Create a pool with 1 click from the debug panel. also adds a button to fund the accounts that are doing the pool creation/borrowing/investing etc.
#2183
Approvals
Screenshots
Impact