Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centrifuge App: Loan portfolio runtime api change #1528

Merged
merged 5 commits into from
Aug 22, 2023

Conversation

onnovisser
Copy link
Collaborator

Description

This pull request...

Closes #

Approvals

  • Dev

Screenshots

Impact

@github-actions
Copy link

github-actions bot commented Aug 14, 2023

PR deployed in Google Cloud
URL: https://app-pr1528.k-f.dev
Commit #: d77e6e0
To access the functions directly check the corresponding deploy Action

},
},
total_borrowed: 'u128',
total_repaid: 'u128',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has changed and should be a RepaidAmount

},
max_borrow_amount: {
_enum: {
NoLimit: 'NoLimit',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be null I guess

presentValue: CurrencyBalance
}
> = {}
;(rawPortfolio as any).forEach(([key, value]: [Codec, Codec]) => {
const data = value.toPrimitive() as any
activeLoansPortfolio[String(key.toPrimitive())] = {
interestAccrued: new CurrencyBalance(data.interest_accrued, 27), // not sure
outstandingPrincipal: new CurrencyBalance(data.outstanding_principal, 27), // not sure about the decimals

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are the same as the currency pool it is related

Copy link
Contributor

@hieronx hieronx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@onnovisser onnovisser merged commit 076d5cc into main Aug 22, 2023
7 checks passed
@onnovisser onnovisser deleted the portfolio-runtime-api-change branch August 22, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants