-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Centrifuge App: Loan portfolio runtime api change #1528
Conversation
PR deployed in Google Cloud |
centrifuge-js/src/CentrifugeBase.ts
Outdated
}, | ||
}, | ||
total_borrowed: 'u128', | ||
total_repaid: 'u128', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has changed and should be a RepaidAmount
centrifuge-js/src/CentrifugeBase.ts
Outdated
}, | ||
max_borrow_amount: { | ||
_enum: { | ||
NoLimit: 'NoLimit', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be null
I guess
centrifuge-js/src/modules/pools.ts
Outdated
presentValue: CurrencyBalance | ||
} | ||
> = {} | ||
;(rawPortfolio as any).forEach(([key, value]: [Codec, Codec]) => { | ||
const data = value.toPrimitive() as any | ||
activeLoansPortfolio[String(key.toPrimitive())] = { | ||
interestAccrued: new CurrencyBalance(data.interest_accrued, 27), // not sure | ||
outstandingPrincipal: new CurrencyBalance(data.outstanding_principal, 27), // not sure about the decimals |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are the same as the currency pool it is related
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Description
This pull request...
Closes #
Approvals
Screenshots
Impact