-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/implement design reporting tab #1384
Closed
Closed
Changes from 26 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
6bb18e6
Refactor Reporting tab
Hornebom 9697988
Design reporting
Hornebom 3b0363c
Merge branch 'main' into feat/implement-design-reporting-tab
Hornebom 6700b5d
Merge branch 'main' into feat/implement-design-reporting-tab
Hornebom 8f61b26
update to latest loan changes
Hornebom a1dbace
Reporting tab
Hornebom ecb1ad1
Merge branch 'main' into feat/implement-design-reporting-tab
Hornebom b2f60c5
removes old Report component
Hornebom 1b4237e
Merge branch 'main' into feat/implement-design-reporting-tab
Hornebom 000db33
remove period
Hornebom 7d220cf
extends ReportContext with range
Hornebom d450fc7
adds currency symbol
Hornebom 3fb1dbc
removes dev setting
Hornebom f2580ea
Merge branch 'main' into feat/implement-design-reporting-tab
Hornebom 55c0b77
formatting table data to human readable strings
Hornebom 8706689
adds currency symbol in front of amount
Hornebom 20f3a2d
visual display reporting tables
Hornebom 8db8bc5
Merge branch 'main' into feat/implement-design-reporting-tab
Hornebom 3a96551
removes developement component rendering
Hornebom 7de8431
Merge branch 'main' into feat/implement-design-reporting-tab
Hornebom 692a308
manually solve merge conflict
Hornebom 560e055
Merge branch 'main' into feat/implement-design-reporting-tab
Hornebom abc568c
Merge branch 'main' into feat/implement-design-reporting-tab
Hornebom 3a9c4c3
refactor to use correct formatting
Hornebom fc3e2db
refactor: removes hidden behind feature flag
Hornebom a811e78
Merge branch 'main' into feat/implement-design-reporting-tab
Hornebom d83961d
refactor: set start date on init useState
Hornebom 85e48a7
refactor: pass ref to custom hook
Hornebom 0fefd2b
Merge branch 'main' into feat/implement-design-reporting-tab
Hornebom a8ae436
Merge branch 'main' into feat/implement-design-reporting-tab
Hornebom File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a better API for this would be
doing a setState for setting the ref seems like a bad idea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
refactored