cefsrc: Apply running time on audio buffers #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philn
force-pushed
the
audio-ts
branch
2 times, most recently
from
573da4b
to
a7c993f
Compare
pyldin601
approved these changes
Nov 30, 2022
|
CI failure looks unrelated to this patch. |
reinismu
reviewed
Dec 8, 2022
|
I checked the latest patch with and without audio. Everything is working.Thanks. |
This should be reverted once we bump our dependency to GStreamer >= 1.18.
Also add an audio meta to buffers, for good measure, and set discont flag when needed. This should help with A/V sync issues reported in centricular#59.
|
lgtm, let's go :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add an audio meta to buffers, for good measure, and set discont flag when needed. This should help with A/V sync issues and audio cracks reported in #59.