-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes small typos and improves clarity in changesets #82
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for this
Originally posted by @aaronmgdr in #66 (comment) @aaronmgdr: As suggested, I made the changes in the changeset files, rather than in CHANGELOG.md directly. I didn't re-generate and commit the changelog manually, because when I ran the command I got the following messages: $ GITHUB_TOKEN=<my-personal-access-token> yarn changeset version
🦋 warn ===============================IMPORTANT!===============================
🦋 warn You are in prerelease mode
🦋 warn If you meant to do a normal release you should revert these changes and run `changeset pre exit`
🦋 warn You can then run `changeset version` again to do a normal release
🦋 warn ----------------------------------------------------------------------
🦋 All files have been updated. Review them and commit at your leisure No CHANGELOG is generated unless I exit prerelease mode. When I exit prerelease mode, the changelog reflects a "production" release (i.e. not beta). I was not sure that exiting prerelease mode is appropriate here. |
@arthurgousset yeah no need to do anything. |
Sounds good, thanks! |
Description
Fixes small typos and improves clarity in changesets created in this PR:
Left comments in #66 a couple of seconds after it was merged. This small PR applies those changes retrospectively.
Tested
No code change
Related issues
Backwards compatibility
No code change