Skip to content

Commit

Permalink
Fix yarn resolution errors (#293)
Browse files Browse the repository at this point in the history
* Fix yarn resolution errors

* remove comment and flag for CI
  • Loading branch information
shazarre authored Jul 15, 2024
1 parent 247f405 commit 75b2749
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 4 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,7 @@ jobs:
restore-keys: |
node-${{ runner.os }}-${{ runner.arch }}-${{ env.NODE_MODULE_CACHE_VERSION }}-
- name: Install yarn dependencies
# skip check due to YN0078: │ Invalid resolution @celo/connect@npm:^5.1.1 → npm:5.1.1
run: git config --global url."https://".insteadOf ssh:// && yarn install --no-check-resolutions
run: git config --global url."https://".insteadOf ssh:// && yarn install
if: steps.cache_node.outputs.cache-hit != 'true'
- name: Run yarn postinstall if cache hitted
run: yarn run postinstall
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"test:watch": "node node_modules/jest/bin/jest.js --watch",
"postinstall": "husky install && yarn workspaces foreach -piv --all run postinstall",
"release": "yarn clean && yarn build && yarn workspace @celo/celocli run prepack && yarn cs publish",
"version-and-reinstall": "yarn changeset version && yarn install --no-immutable --no-check-resolutions",
"version-and-reinstall": "yarn changeset version && yarn install --no-immutable",
"celocli": "yarn workspace @celo/celocli run --silent celocli"
},
"workspaces": {
Expand Down
4 changes: 3 additions & 1 deletion packages/sdk/contractkit/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,13 @@
"@celo/typescript": "workspace:^",
"@truffle/contract": "4.6.31",
"@types/debug": "^4.1.5",
"@types/node": "18.7.16",
"bn.js": "^5.1.0",
"fetch-mock": "^10.0.7",
"ganache": "npm:@celo/[email protected]",
"jest": "^29.7.0",
"ts-node": "^10.9.1"
"ts-node": "^10.9.1",
"typescript": "5.3.3"
},
"engines": {
"node": ">=8.14.2"
Expand Down
2 changes: 2 additions & 0 deletions packages/sdk/wallets/wallet-ledger/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,9 @@
"@noble/curves": "^1.4.0",
"@noble/hashes": "^1.3.3",
"@types/debug": "^4.1.12",
"@types/node": "18.7.16",
"ts-node": "^10.9.2",
"typescript": "5.3.3",
"web3": "1.10.4"
},
"engines": {
Expand Down
4 changes: 4 additions & 0 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1770,6 +1770,7 @@ __metadata:
"@truffle/contract": "npm:4.6.31"
"@types/bn.js": "npm:^5.1.0"
"@types/debug": "npm:^4.1.5"
"@types/node": "npm:18.7.16"
bignumber.js: "npm:^9.0.0"
bn.js: "npm:^5.1.0"
cross-fetch: "npm:3.1.5"
Expand All @@ -1781,6 +1782,7 @@ __metadata:
jest: "npm:^29.7.0"
semver: "npm:^7.3.5"
ts-node: "npm:^10.9.1"
typescript: "npm:5.3.3"
web3: "npm:1.10.4"
web3-core-helpers: "npm:1.10.4"
languageName: unknown
Expand Down Expand Up @@ -2197,9 +2199,11 @@ __metadata:
"@noble/curves": "npm:^1.4.0"
"@noble/hashes": "npm:^1.3.3"
"@types/debug": "npm:^4.1.12"
"@types/node": "npm:18.7.16"
debug: "npm:^4.1.1"
semver: "npm:^7.6.0"
ts-node: "npm:^10.9.2"
typescript: "npm:5.3.3"
web3: "npm:1.10.4"
languageName: unknown
linkType: soft
Expand Down

0 comments on commit 75b2749

Please sign in to comment.