Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove BinanceUS from USDCUSD oracle config #10395

Closed
wants to merge 3 commits into from

Conversation

nvtaveras
Copy link
Collaborator

Description

Due to the Binance US recent issues the USDCUSD pair is trading at a discounted rate (because of the problems with USD withdrawals), which is causing the clients to stop reporting due to the following error:

"message":"Max price cross-sectional deviation too large (0.02774727286026238157 >= 0.01 )","name":"Error","stack":"Error: Max price cross-sectional deviation too large (0.02774727286026238157 >= 0.01

This removes the exchange from the config until we find a better solution

Other changes

Tested

Already deployed and running

Related issues

Backwards compatibility

Documentation

@nvtaveras nvtaveras requested a review from a team June 23, 2023 11:35
@nvtaveras nvtaveras requested a review from a team as a code owner June 23, 2023 11:35
@nvtaveras nvtaveras requested a review from alvarof2 June 23, 2023 11:35
Copy link
Collaborator

@sissnad sissnad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nvtaveras nvtaveras enabled auto-merge (squash) June 23, 2023 13:42
@nvtaveras nvtaveras changed the title Remove binanceUS from USDCUSD oracle config Remove BinanceUS from USDCUSD oracle config Jun 23, 2023
@nvtaveras nvtaveras changed the title Remove BinanceUS from USDCUSD oracle config fix: remove BinanceUS from USDCUSD oracle config Jun 23, 2023
auto-merge was automatically disabled June 29, 2023 09:58

Base branch was modified

@nvtaveras
Copy link
Collaborator Author

This will be updated in a different PR where we do a wider oracle config update.

@nvtaveras nvtaveras closed this Sep 26, 2023
@lvpeschke lvpeschke deleted the chore/removeBinanceUsFromUSDC branch November 9, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants