ODIS V1 Sunset (#10444)

* removed legacy code * ∆ PnpSignAction and PnpQuotaService to non-abstract class * renamed variable * removed empty test * lowered coverage threshold by 3% * add back legacy accounts table for now (#10450) * update sdk/identity * deprecate `endpoint` variable * removed todo comment * removed commented var * increased fetch_depth * increase all fetch_depth * ∆ `pull_request_target` to `pull_request` * bump version * remove endpoint var from call to ODIS * decreased code coverage to threshold to 76% --------- Co-authored-by: Alec Schaefer <[email protected]>
celo-org · Aug 2, 2023 · 6b3decd · 6b3decd
1 parent 21cdce6
commit 6b3decd
Show file tree

Hide file tree

Showing 41 changed files with 68 additions and 4,514 deletions.
diff --git a/.github/workflows/circleci.yml b/.github/workflows/circleci.yml
@@ -460,9 +460,9 @@ jobs:
           package-json-checksum: ${{ needs.install-dependencies.outputs.package-json-checksum }}
       - name: Get changed files
         id: changed-files
-        uses: tj-actions/changed-files@v35
+        uses: tj-actions/changed-files@v37
         with:
-          fetch_depth: '100'
+          fetch_depth: '150'
       - name: Generate DevChain
         run: |
           cd packages/sdk/identity

diff --git a/packages/phone-number-privacy/combiner/src/common/sign.ts b/packages/phone-number-privacy/combiner/src/common/sign.ts
@@ -2,7 +2,6 @@ import {
   DomainRestrictedSignatureRequest,
   ErrorMessage,
   ErrorType,
-  LegacySignMessageRequest,
   OdisResponse,
   responseHasExpectedKeyVersion,
   SignMessageRequest,
@@ -18,8 +17,8 @@ import { IO } from './io'
 // prettier-ignore
 export type OdisSignatureRequest =
   | SignMessageRequest
-  | LegacySignMessageRequest
   | DomainRestrictedSignatureRequest
+
 export type ThresholdStateService<R extends OdisSignatureRequest> = R extends SignMessageRequest
   ? PnpThresholdStateService<R>
   : never | R extends DomainRestrictedSignatureRequest

diff --git a/packages/phone-number-privacy/combiner/src/pnp/endpoints/quota/io.ts b/packages/phone-number-privacy/combiner/src/pnp/endpoints/quota/io.ts
@@ -5,7 +5,6 @@ import {
   ErrorType,
   getSignerEndpoint,
   hasValidAccountParam,
-  identifierIsValidIfExists,
   isBodyReasonablySized,
   PnpQuotaRequest,
   PnpQuotaRequestSchema,
@@ -57,7 +56,6 @@ export class PnpQuotaIO extends IO<PnpQuotaRequest> {
     return (
       super.validateClientRequest(request) &&
       hasValidAccountParam(request.body) &&
-      identifierIsValidIfExists(request.body) &&
       isBodyReasonablySized(request.body)
     )
   }

diff --git a/packages/phone-number-privacy/combiner/src/pnp/endpoints/sign/action.ts b/packages/phone-number-privacy/combiner/src/pnp/endpoints/sign/action.ts
@@ -1,7 +1,6 @@
 import {
   ErrorMessage,
   ErrorType,
-  LegacySignMessageRequest,
   SignMessageRequest,
   WarningMessage,
 } from '@celo/phone-number-privacy-common'
@@ -12,7 +11,7 @@ import { PnpSignerResponseLogger } from '../../services/log-responses'
 export class PnpSignAction extends SignAction<SignMessageRequest> {
   readonly responseLogger: PnpSignerResponseLogger = new PnpSignerResponseLogger()
 
-  combine(session: CryptoSession<SignMessageRequest | LegacySignMessageRequest>): void {
+  combine(session: CryptoSession<SignMessageRequest>): void {
     this.responseLogger.logResponseDiscrepancies(session)
     this.responseLogger.logFailOpenResponses(session)
 
@@ -41,7 +40,7 @@ export class PnpSignAction extends SignAction<SignMessageRequest> {
     this.handleMissingSignatures(session)
   }
 
-  protected parseBlindedMessage(req: SignMessageRequest | LegacySignMessageRequest): string {
+  protected parseBlindedMessage(req: SignMessageRequest): string {
     return req.blindedQueryPhoneNumber
   }
 

diff --git a/packages/phone-number-privacy/combiner/src/pnp/endpoints/sign/io.legacy.ts b/packages/phone-number-privacy/combiner/src/pnp/endpoints/sign/io.legacy.ts
diff --git a/packages/phone-number-privacy/combiner/src/server.ts b/packages/phone-number-privacy/combiner/src/server.ts
@@ -24,7 +24,6 @@ import { PnpQuotaAction } from './pnp/endpoints/quota/action'
 import { PnpQuotaIO } from './pnp/endpoints/quota/io'
 import { PnpSignAction } from './pnp/endpoints/sign/action'
 import { PnpSignIO } from './pnp/endpoints/sign/io'
-import { LegacyPnpSignIO } from './pnp/endpoints/sign/io.legacy'
 import { PnpThresholdStateService } from './pnp/services/threshold-state'
 
 require('events').EventEmitter.defaultMaxListeners = 15
@@ -61,23 +60,6 @@ export function startCombiner(config: CombinerConfig, kit: ContractKit) {
 
   const pnpThresholdStateService = new PnpThresholdStateService()
 
-  const legacyPnpSign = new Controller(
-    new PnpSignAction(
-      config.phoneNumberPrivacy,
-      pnpThresholdStateService,
-      new LegacyPnpSignIO(config.phoneNumberPrivacy, kit)
-    )
-  )
-  app.post(CombinerEndpoint.LEGACY_PNP_SIGN, (req, res) =>
-    meterResponse(
-      legacyPnpSign.handle.bind(legacyPnpSign),
-      req,
-      res,
-      CombinerEndpoint.LEGACY_PNP_SIGN,
-      config
-    )
-  )
-
   const pnpQuota = new Controller(
     new PnpQuotaAction(
       config.phoneNumberPrivacy,