Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!(core): enable tls for grpc connection #3922

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

vgonkivs
Copy link
Member

@vgonkivs vgonkivs commented Nov 6, 2024

This PR includes all changes from #3917.
The PR introduces 2 additional fields in the core config and 2 cli flags that allow to configure these fields.

@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 26.44628% with 89 lines in your changes missing coverage. Please review.

Project coverage is 45.16%. Comparing base (2469e7a) to head (3829eeb).
Report is 378 commits behind head on main.

Files with missing lines Patch % Lines
state/core_access.go 32.72% 33 Missing and 4 partials ⚠️
nodebuilder/core/tls.go 0.00% 33 Missing ⚠️
nodebuilder/state/core.go 0.00% 11 Missing ⚠️
nodebuilder/core/flags.go 63.63% 6 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3922      +/-   ##
==========================================
+ Coverage   44.83%   45.16%   +0.33%     
==========================================
  Files         265      308      +43     
  Lines       14620    21936    +7316     
==========================================
+ Hits         6555     9908    +3353     
- Misses       7313    10951    +3638     
- Partials      752     1077     +325     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vgonkivs vgonkivs changed the title improvements to pr-3917 feat!(core): enable tls for grpc connection Nov 6, 2024
@vgonkivs vgonkivs self-assigned this Nov 6, 2024
@vgonkivs vgonkivs added kind:break! Attached to breaking PRs kind:feat Attached to feature PRs labels Nov 6, 2024
@vgonkivs vgonkivs marked this pull request as ready for review November 6, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:break! Attached to breaking PRs kind:feat Attached to feature PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants