-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!(core): enable tls for grpc connection #3922
Open
vgonkivs
wants to merge
6
commits into
celestiaorg:main
Choose a base branch
from
vgonkivs:grpc_tls
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3922 +/- ##
==========================================
+ Coverage 44.83% 45.16% +0.33%
==========================================
Files 265 308 +43
Lines 14620 21936 +7316
==========================================
+ Hits 6555 9908 +3353
- Misses 7313 10951 +3638
- Partials 752 1077 +325 ☔ View full report in Codecov by Sentry. |
vgonkivs
changed the title
improvements to pr-3917
feat!(core): enable tls for grpc connection
Nov 6, 2024
vgonkivs
added
kind:break!
Attached to breaking PRs
kind:feat
Attached to feature PRs
labels
Nov 6, 2024
vgonkivs
requested review from
renaynay,
Wondertan,
walldiss and
cristaloleg
as code owners
November 6, 2024 13:32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes all changes from #3917.
The PR introduces 2 additional fields in the core config and 2 cli flags that allow to configure these fields.