-
Notifications
You must be signed in to change notification settings - Fork 44
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
4ee7e05
commit 317e88b
Showing
2 changed files
with
112 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
| cip | XX (assigned by Editors) | | ||
| - | - | | ||
| title | Nonce Aware Mempool | | ||
| description | Mempool to prioritize transactions where nonce takes presedence | | ||
| author | @ninabarbakadze | | ||
| discussions-to | TODO: post discussions | | ||
| status | Draft | | ||
| type | Standards Track, Meta, or Informational | | ||
| category | Core, Data Availability, Networking, Interface, or CRC. Only required for Standards Track. Otherwise, remove this field. | | ||
| created | Date created on, in ISO 8601 (2024-09-20) format | | ||
|
||
## Abstract | ||
|
||
To improve transaction submission reliability, we propose implementing a nonce-aware priority mempool. This approach aims to reduce transaction eviction likelihood by ordering txs by nonce and priority, ensuring high-priority transactions are processed sooner while maintaining nonce order. | ||
|
||
## Specification | ||
|
||
The Specification section should describe the syntax and semantics of any new feature. The specification should be detailed enough to allow competing, interoperable implementations for any of the current Celestia clients (celestia-node, celestia-core, celestia-app). | ||
|
||
It is recommended to follow RFC 2119 and RFC 8170. Do not remove the key word definitions if RFC 2119 and RFC 8170 are followed. | ||
|
||
TODO: Remove the previous comments before submitting | ||
|
||
The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL NOT", "SHOULD", "SHOULD NOT", "RECOMMENDED", "NOT RECOMMENDED", "MAY", and "OPTIONAL" in this document are to be interpreted as described in RFC 2119 and RFC 8174. | ||
|
||
## Rationale | ||
|
||
The rationale fleshes out the specification by describing what motivated the design and why particular design decisions were made. It should describe alternate designs that were considered and related work, e.g. how the feature is supported in other languages. | ||
|
||
The current placeholder is acceptable for a draft. | ||
|
||
TODO: Remove the previous comments before submitting | ||
|
||
## Backwards Compatibility | ||
|
||
This feature is ABCI breaking and tendermint API breaking. | ||
|
||
## Test Cases | ||
|
||
This section is optional. | ||
|
||
The Test Cases section should include expected input/output pairs, but may include a succinct set of executable tests. It should not include project build files. No new requirements may be be introduced here (meaning an implementation following only the Specification section should pass all tests here.) | ||
|
||
If the test suite is too large to reasonably be included inline, then consider adding it as one or more files in `../assets/cip-####/`. External links will not be allowed | ||
|
||
TODO: Remove the previous comments before submitting | ||
|
||
## Reference Implementation | ||
|
||
## Security Considerations | ||
|
||
Potential DOS attack. Users can keep increasing the fee and cause excessive transaction resending. | ||
|
||
## Copyright | ||
|
||
Copyright and related rights waived via [CC0](https://github.com/celestiaorg/CIPs/blob/main/LICENSE). |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
| cip | 24 | | ||
| - | - | | ||
| title | Versioned Gas Scheduler Variables | | ||
| description | Transition to hard fork-only updates for gas scheduler variables | | ||
| author | Nina Barbakadze (@ninabarbakadze) | | ||
| discussions-to | | | ||
| status | Draft | | ||
| type | Standards Track | | ||
| category | Core | | ||
| created | 2024-07-24 | | ||
|
||
## Abstract | ||
|
||
Gas scheduler parameters `blob.GasPerBlobByte` and `auth.TxSizeCostPerByte` will no longer be modifiable by governance but may only change via a hard fork upgrade. | ||
|
||
## Motivation | ||
|
||
Versioning on-chain governance modifiable parameters `blob.GasPerBlobByte` and `auth.TxSizeCostPerByte`, aims to stabilize gas estimation by removing block-to-block variability. This allows for hardcoding these values into estimators, simplifying the gas estimation process and making transaction costs more predictable without the need for pre-transaction queries. | ||
|
||
## Specification | ||
|
||
Currently, `GasPerBlobByte` and `TxSizeCostPerByte` are module parameters within the `blob` and `auth` modules, allowing for their modification via `ParameterChangeProposal`. The proposed modification changes these parameters to hardcoded constants within the application, accessible via version-specific getters. | ||
|
||
### Parameters | ||
|
||
The proposal makes these two variables modifiable through hard fork upgrades: | ||
|
||
Previously: | ||
|
||
1. `blob.GasPerBlobByte` | ||
2. `auth.TxSizeCostPerByte` | ||
|
||
Now: | ||
|
||
1. `appconsts.GasPerBlobByte` | ||
1. `appconsts.TxSizeCostPerByte` | ||
|
||
## Backwards Compatibility | ||
|
||
Enabling this feature requires a hard fork network upgrade. | ||
|
||
## Test Cases | ||
|
||
Test cases should verify that gas scheduler variables are exclusively updated via hard forks, effectively preventing updates through governance mechanisms and that the gas meter uses those constants. | ||
|
||
## Reference Implementation | ||
|
||
TBC | ||
|
||
## Security Considerations | ||
|
||
This change prioritizes network stability and predictability but requires heightened vigilance against potential misconfigurations. | ||
|
||
## Copyright | ||
|
||
Copyright and related rights waived via [CC0](https://github.com/celestiaorg/CIPs/blob/main/LICENSE). |